test: Fix test-fs-read-stream-fd-leak race cond #3218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-yan
force-pushed
the
fix-test-fd-leak
branch
from
5d9769b to
a47311f
Compare
john-yan
changed the title
|
LGTM |
|
CI run started here: https://ci.nodejs.org/job/node-test-pull-request/457/ |
|
CI run looks good |
mhdawson
pushed a commit
that referenced
this pull request
Oct 8, 2015
Fix intermittent test failure on slower machines. Gives test longer time to complete but checks at regular intervals so that the test only runs longer on slower machines or in the failure case. PR-URL: #3218 Fixes: #3215 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James Snell <[email protected]>>
|
landed as 8aa589c |
|
Will leave open until it gets pulled into 4.X |
jasnell
pushed a commit
that referenced
this pull request
Oct 8, 2015
Fix intermittent test failure on slower machines. Gives test longer time to complete but checks at regular intervals so that the test only runs longer on slower machines or in the failure case. PR-URL: #3218 Fixes: #3215 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James Snell <[email protected]>>
|
Landed in v4.x with 7c85557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem #3215 by redo checking for openCount in slow running environment.