lib: refactor ServerResponse.prototype.writeHead #32399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himself65
force-pushed
the
20200321-refactor-writeHead
branch
4 times, most recently
from
137b347 to
70ca662
Compare
spazmodius
reviewed
Mar 21, 2020
himself65
force-pushed
the
20200321-refactor-writeHead
branch
from
70ca662 to
10962bc
Compare
starkwang
reviewed
Mar 26, 2020
| @@ -150,7 +150,7 @@ const s = http.createServer(common.mustCall((req, res) => { | |||
| case 'writeHead': | |||
| res.statusCode = 404; | |||
| res.setHeader('x-foo', 'keyboard cat'); | |||
| res.writeHead(200, { 'x-foo': 'bar', 'x-bar': 'baz' }); | |||
| res.writeHead(200, undefined, { 'x-foo': 'bar', 'x-bar': 'baz' }); | |||
There was a problem hiding this comment.
Should we also keep the test case for writeHead(status[, headers])?
There was a problem hiding this comment.
Yes, I'm looking for a suitable test file to add this new case
There was a problem hiding this comment.
@himself65 ping, did you get any further with this?
There was a problem hiding this comment.
oh no, I have forgot about this...
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
|
@himself65 This needs a rebase. |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #32395
make
HTTPandHTTP2the behavior the same.example, allow
response.writeHead(200, undefined, { ...headers })when the second parameter is undefined passingnode/lib/internal/http2/compat.js
Lines 608 to 620 in d129e0c
btw, I renamed the name of parameters for better coding experience
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes