Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note re term-size commit on top of npm #32403

Closed
wants to merge 3 commits into from
Closed

doc: add note re term-size commit on top of npm #32403

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4521ec
doc: add note re term-size commit on top of npm
rvagg Mar 21, 2020
341550a
fixup! doc: add note re term-size commit on top of npm
rvagg Mar 23, 2020
8a12af6
fixup! doc: add note re term-size commit on top of npm
rvagg Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion doc/guides/maintaining-npm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,24 @@ Note: please ensure you are only making the updates that are changed by npm.
$ git rebase --whitespace=fix master
```

## Step 7: Test the build
## Step 7: Apply signed term-size commit

The `term-size` package in npm's dependency tree contains an unsigned macOS
binary in versions < 2.2.0. Until npm updates to a newer version of
`update-notifier`, Node.js macOS package files can't be notarized and will fail
to install on macOS Catalina and above.

When `npm ls` shows a `term-size` package version < 2.2.0, cherry-pick
commit `d2f08a1bdb` on top of the upgraded npm.

```console
$ git cherry-pick d2f08a1bdb
```

When `npm ls` shows a `term-size` package version >= 2.2.0, edit this file to
remove this step.

## Step 8: Test the build

```console
$ make test-npm
Expand Down