-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: onboarding process extras #34455
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
approved these changes
Jul 21, 2020
4 tasks
Related question: Is it common for onboarding to be done with just one existing collaborator present? |
addaleax
approved these changes
Jul 21, 2020
Trott
reviewed
Jul 21, 2020
Trott
approved these changes
Jul 21, 2020
gireeshpunathil
added a commit
that referenced
this pull request
Jul 24, 2020
Callout some practices explicitly, so that the process is followed in a similar manner PR-URL: #34455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
gireeshpunathil
force-pushed
the
obboarding-extras
branch
from
July 24, 2020 04:42
f45a426
to
983364c
Compare
landed in 983364c |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Callout some practices explicitly, so that the process is followed in a similar manner PR-URL: #34455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Callout some practices explicitly, so that the process is followed in a similar manner PR-URL: #34455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Callout some practices explicitly, so that the process is followed in a similar manner PR-URL: #34455 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Andrey Pechkurov <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callout some practices explicitly, so that the process is followed in a similar manner
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes