Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: do not hardcode Debugger.CallFrameId in tests #35570

Closed
wants to merge 1 commit into from

Commits on Oct 9, 2020

  1. inspector: do not hardcode Debugger.CallFrameId in tests

    Debugger.CallFrameId is defined as an opaque string [1].
    
    Some tests currently hardcode the value, relying on
    undocumented internal details of V8. This makes it hard
    for V8 to change the internal representation.
    
    We should instead use the reported call frame id from
    the Debugger.paused event directly. This is how every
    inspector client does it.
    
    [1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId
    dgozman committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    7f1faa7 View commit details
    Browse the repository at this point in the history