n-api: fix test_async_context warnings #36171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Schulhof <[email protected]>
legendecas
approved these changes
Nov 19, 2020
Flarna
approved these changes
Nov 19, 2020
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Nov 19, 2020
Trott
approved these changes
Nov 20, 2020
|
Requesting fast-track as I think it's uncontroversial and would be good to address the warnings |
gabrielschulhof
pushed a commit
that referenced
this pull request
Nov 20, 2020
Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
|
Landed in 551d8c4. |
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36171 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: @gabrielschulhof
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes