Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update eslint to 8.18.0 #43479

Merged
merged 2 commits into from
Jun 19, 2022
Merged

tools: update eslint to 8.18.0 #43479

merged 2 commits into from
Jun 19, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of eslint to 8.18.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 19, 2022
@lpinca lpinca force-pushed the actions/tools-update-eslint branch from 2fc868f to b48b9f0 Compare June 19, 2022 07:43
@aduh95
Copy link
Contributor

aduh95 commented Jun 19, 2022

i think this need to be one commit, otherwise there's going to be at least one commit that doesn't pass the CI on main

node/doc/contributing/pull-requests.md

Lines 540 to 541 in 3296d6d

and the tests, but is still one logical change. All tests should always pass
when each individual commit lands on one of the `nodejs/node` branches.

@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 19, 2022
Trott
Trott approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2022
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44716/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2022
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44731/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 9c3c66b into main Jun 19, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 9c3c66b

@Trott Trott deleted the actions/tools-update-eslint branch June 19, 2022 22:06
This was referenced Jun 20, 2022
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@nodejs-github-bot @targos
tools: update eslint to 8.18.0
59d4da6 
PR-URL: #43479
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 12, 2022
@nodejs-github-bot @targos
tools: update eslint to 8.18.0
0e7c70c 
PR-URL: #43479
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
tools: update eslint to 8.18.0
29976a3 
PR-URL: #43479
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
tools: update eslint to 8.18.0
a9387c8 
PR-URL: nodejs/node#43479
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nodejs-github-bot @aduh95 @Trott @lpinca @targos @cjihrig @VoltrexKeyva