Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add single executable application initiative #43611

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

mhdawson
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2022
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @jesec

Should we also reference https://github.com/nodejs/node/issues/43432 in the description because that's the tracking issue for the SEA initiative?

@mhdawson
Copy link
Member Author

@RaisinTen

Should we also reference nodejs/single-executable#75 in the description because that's the tracking issue for the SEA initiative?

Done

@jesec
Copy link
Member

jesec commented Jun 30, 2022

LGTM! 👍

@mhdawson Thanks.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2de8dd1 into nodejs:main Jul 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 2de8dd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants