Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace_events: fix getCategories #45092

Merged
merged 1 commit into from
Oct 24, 2022
Merged

trace_events: fix getCategories #45092

merged 1 commit into from
Oct 24, 2022

Conversation

theanarkh
Copy link
Contributor

fix getCategories of trace_events.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 20, 2022
@theanarkh theanarkh force-pushed the fix_trace_event_categorys branch from c9aa695 to a072817 Compare October 20, 2022 14:35
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@theanarkh theanarkh force-pushed the fix_trace_event_categorys branch from a072817 to 9d3e05c Compare October 22, 2022 14:35
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2022
@github-actions github-actions bot mentioned this pull request Oct 23, 2022
Open
13 tasks
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47418/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47428/

@github-actions github-actions bot mentioned this pull request Oct 24, 2022
Open
13 tasks
@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit aab9f32 into nodejs:main Oct 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in aab9f32

This was referenced Oct 25, 2022
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@theanarkh @RafaelGSS
trace_events: fix getCategories
d5ada0f 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@theanarkh theanarkh mentioned this pull request Nov 1, 2022
Merged
4 tasks
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@theanarkh @RafaelGSS
trace_events: fix getCategories
732f9a7 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2022
@theanarkh
trace_events: add new categories
bcc704f 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@theanarkh @ruyadorno
trace_events: add new categories
f441b04 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@theanarkh @marco-ippolito
trace_events: add new categories
1b53059 
PR-URL: nodejs#45266
Refs: nodejs#45092
Refs: nodejs#44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: fix getCategories
c1509bb 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: add new categories
2275255 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: fix getCategories
9f721e6 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: add new categories
a2256ba 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
trace_events: fix getCategories
20a39a3 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
trace_events: add new categories
210cbcb 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@theanarkh @danielleadams
trace_events: add new categories
e83c5ee 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@theanarkh @danielleadams
trace_events: add new categories
31d2ce8 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@F3n67u F3n67u F3n67u approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theanarkh @nodejs-github-bot @jasnell @anonrig @F3n67u @RaisinTen