-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: add recursive watch for linux #45098
Merged
nodejs-github-bot
merged 38 commits into
nodejs:main
from
anonrig:fs/add-recursive-watch
Oct 31, 2022
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
cdc9349
fs: add recursive watch to linux
anonrig 296646b
fs: replace traverse with readdir for performance
anonrig 77cb9a0
fs: fix linter issues
anonrig 5b72449
fs: move linux watcher to internal/fs/watch
anonrig 87866c3
test: add missing clear interval for linux
anonrig 00ab12d
fs: add promise support to linux watcher
anonrig cb4b455
test: simplify start and update tests
anonrig 4144949
fs: avoid prototype pollution
anonrig 9a86410
test: improve fs.watch tests
anonrig 8b36541
test: handle edge cases
anonrig 89abb18
fs: handle more linux edge cases
anonrig f15251f
fs: update requested changes
anonrig cd240a6
fs: fix circular dependency
anonrig 6311cf5
fs: improve tests
anonrig d8d2a0c
test: add url as parameter for fs.watch
anonrig 632a4bc
test: update lint errors
anonrig df610ef
test: fix url error
anonrig 8243dde
test: improve test-fs-watch-recursive.js
anonrig 37a0839
fs: use arrays instead of sets
anonrig c7512ef
fs: remove lazy loading assert
anonrig 6eee878
fs: revert certain changes
anonrig a6906f2
fs: add recursive validation to linux watcher
anonrig 6061330
test: improve tests
anonrig 9d596e8
fs: do not throw abort errors
anonrig d94f365
fs: rename recursive watch
anonrig b5161e5
fs: adjust implementation
anonrig 6e4299d
fs: add ref and unref to fs.watch
anonrig 2e5d4b3
fs: update async iterator implementation
anonrig cd3199b
fs: improve watcher
anonrig d69a565
fs: rename linux watcher
anonrig 28ee387
fs: add support for symlinks
anonrig 8e4e3dd
test: remove redundant test
anonrig e6019be
fs: rename to nonNativeWatcher
anonrig 1e903a2
fs: update comments
anonrig b8b87f6
test: update symlink error message
anonrig ab4f1d2
fs: update implementation
anonrig c11bb62
test: make fs.watch errors more strict
anonrig bddb83f
fs: add documentation
anonrig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still true that it is unavailable in some situations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IBMi and AIX does not fully support
fs.watch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a task for later (follow on PR) it would be good to explain a bit more what "situations" it is unavailable.