buffer: remove unnecessary lazy loading #45807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Dec 10, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
11 tasks
aduh95
added
review wanted
11 tasks
MoLow
approved these changes
Dec 12, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6cef4a6 |
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45807 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
13 tasks
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45807 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
12 tasks
|
@aduh95 this broke tests when landing in v18.x-staging. Do you mind opening a backport PR? |
danielleadams
added
the
backport-requested-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/urlis snapshotted, so there's no benefit in lazy loading it. The comment above says something about circular dependency, but that doesn't seem to apply anymore.