-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add text around collaborative expectations #46121
Conversation
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]>
Did something prompt this? The blurb has a strong "water is wet, news at 11" vibe and the README is already interminably long... Aside: I'd be in favor of moving out the collaborators/triagers/etc. lists. |
Co-authored-by: Rich Trott <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Rich Trott <[email protected]>
@Trott I've incorporate all of your suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Would expect it below code of conduct, but that's not very signiciant.)
I think the open questions have been discussed/answered. I meant to tag the TSC at begining with @nodejs/tsc which I'm doing now so that we get more TSC review before it lands. @nodejs/tsc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ok going to go ahead and land. |
Landed in c62a860 |
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
- add text discussed by the TSC Signed-off-by: Michael Dawson <[email protected]> PR-URL: #46121 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Signed-off-by: Michael Dawson [email protected]