doc: add emit to NodeEventTarget #46356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeEventTarget.emit() is not described in document. Plus, make type parameter of removeAllListeners as optional. Refs: nodejs#35851
|
/cc @nodejs/events |
lpinca
approved these changes
Jan 28, 2023
lpinca
added
request-ci
jasnell
reviewed
Jan 29, 2023
Co-authored-by: James M Snell <[email protected]>
aymen94
approved these changes
Feb 3, 2023
|
@benjamingr Could you please review this PR because this PR adds document for API you implemented? |
|
@deokjinkim first: feel free to ping me for review whenever :) Second: NodeEventTarget was @jasnell and a bit of @addaleax , I was a distant third (I did work a bunch on EventTarget just not those parts). |
benjamingr
approved these changes
Feb 9, 2023
deokjinkim
added
doc
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4139956554 |
deokjinkim
added
author ready
github-actions
bot
removed
the
request-ci
32 tasks
deokjinkim
added a commit
that referenced
this pull request
Feb 20, 2023
NodeEventTarget.emit() is not described in document. Plus, make type parameter of removeAllListeners as optional. Refs: #35851 PR-URL: #46356 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Landed in ac7ef31 |
This was referenced Feb 21, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
NodeEventTarget.emit() is not described in document. Plus, make type parameter of removeAllListeners as optional. Refs: #35851 PR-URL: #46356 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
NodeEventTarget.emit() is not described in document. Plus, make type parameter of removeAllListeners as optional. Refs: #35851 PR-URL: #46356 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeEventTarget.emit() is not described in document. Plus, make type parameter of removeAllListeners as optional.
Refs: #35851