doc: document how to use the tls.DEFAULT_CIPHERS #46482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DEFAULT_CIPHERS already exists, this change shows how to use it. Fixes: nodejs#46462
nodejs-github-bot
added
doc
|
Would it be cheeky to request this goes into v18 too? I don't know how that's done if possible... |
|
cc @nodejs/crypto
Since Node.js 18 is in active maintenance it should eventually get semver-minor and semver-patch updates once they've gone out in a current release. I'll add the watch label anyway, as it is an extra thing checked when we prepare releases. |
|
D'oh, forgot the linter gets run in inlined code! |
lpinca
approved these changes
Feb 3, 2023
lpinca
added
the
commit-queue-squash
VoltrexKeyva
reviewed
Feb 5, 2023
Remove extraneous quotes Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
aymen94
approved these changes
Feb 6, 2023
jasnell
approved these changes
Feb 7, 2023
|
Is there anything I need to do to get this merged? |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 42be7f6 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
The DEFAULT_CIPHERS already exists, this change shows how to use it. Fixes: #46462 PR-URL: #46482 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
The DEFAULT_CIPHERS already exists, this change shows how to use it. Fixes: #46462 PR-URL: #46482 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added
backported-to-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tls.DEFAULT_CIPHERSvar already exists, this change shows how to use it.Fixes: #46462
I have attempted to keep my changes in style with the rest, I tried finding the
Style Guidebut the link just sent me back to the top-levelREADME.mdso I couldn't find it.I hope this is helpful!