test: fix IPv6 checks on IBM i #46546
Conversation
nodejs-github-bot
added
needs-ci
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4127678728 |
richardlau
added
the
commit-queue-squash
richardlau
removed
the
request-ci-failed
richardlau
added
ibm i
|
@abmusse Can you rebase this to fix the conflict? |
abmusse
force-pushed
the
ibmi-ipv6-test-fix
branch
from
9b4f649 to
6871813
Compare
@richardlau |
github-actions
bot
removed
the
request-ci
FWIW I ran an IBM i CI build for this: |
Good catch @richardlau I need to apply the same errno 42 check in that file as well! else if (common.isIBMi) {
// IBMi returns EUNATCH (ERRNO 42) when IPv6 is disabled
// keep this errno assertion until EUNATCH is recognized by libuv
assert.strictEqual(error.errno, -42);
}Update added fix in |
github-actions
bot
removed
the
request-ci
|
CI: https://ci.nodejs.org/job/node-test-pull-request/49892/ |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c2c61e0 |
juanarbol
added
the
backport-requested-v18.x
|
This is not landing cleanly on v18.x |
|
@juanarbol This hasn't gone out in a current release yet so it's too early to be considered for v18.x. |
PR-URL: #46546 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: #48050 Refs: #48049 Refs: #46546 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: #48050 Refs: #48049 Refs: #46546 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: nodejs#48050 Refs: nodejs#48049 Refs: nodejs#46546 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #46546 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#46546 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#46546 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This fix should help resolve some test failures:
That fail with:
The issues I discovered were 2 fold:
The
hasIPv6function cannot determine IPv6 on IBM i. The loop back interface on IBM i is named*LOOPBACK.When IPv6 is disabled IBM i returns EUNATCH (errno 42). For now, I've added an errno check in test case for. I believe that libuv needs to get updated to handle EUNATCH so that the error code can be addressed as
EUNATCH. Similar to include: add EOVERFLOW status code mapping libuv/libuv#3145CC @nodejs/platform-ibmi
CC @richardlau