Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update ada to v1.0.1 #46550

Closed
wants to merge 2 commits into from
Closed

deps: update ada to v1.0.1 #46550

wants to merge 2 commits into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 7, 2023

Fixing the bug in update-ada.sh script, and updating the file to the latest version.

@anonrig anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Feb 7, 2023
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 7, 2023
@anonrig anonrig changed the title Update ada to v1 0 1 deps: update ada to v1.0.1 Feb 7, 2023
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig
Copy link
Member Author

anonrig commented Feb 7, 2023

cc @nodejs/url

@anonrig anonrig mentioned this pull request Feb 7, 2023
Closed
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/4118887220

@jasnell
Copy link
Member

jasnell commented Feb 7, 2023

Ci has been locked for pending security release. It'll be released for use again tomorrow probably.

@richardlau
Copy link
Member

Ci has been locked for pending security release. It'll be released for use again tomorrow probably.

FYI The security releases are next Tuesday, 14 February. The CI will be locked down until at least then.

@tniessen tniessen removed fast-track PRs that do not need to wait for 48 hours to land. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 8, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2023
@TimothyGu TimothyGu added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 16, 2023
@anonrig anonrig removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 65854f1...8eb8e7a

nodejs-github-bot pushed a commit that referenced this pull request Feb 17, 2023
@anonrig @nodejs-github-bot
tools: fix update-ada script
36402f0 
PR-URL: #46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 17, 2023
@anonrig @lemire @nodejs-github-bot
deps: update ada to v1.0.1
8eb8e7a 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: #46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@anonrig anonrig deleted the update-ada-to-v1-0-1 branch February 17, 2023 16:01
@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Open
32 tasks
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@anonrig @MylesBorins
tools: fix update-ada script
06d032b 
PR-URL: #46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@anonrig @lemire @MylesBorins
deps: update ada to v1.0.1
8822874 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: #46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@anonrig @MylesBorins
tools: fix update-ada script
87df34a 
PR-URL: #46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@anonrig @lemire @MylesBorins
deps: update ada to v1.0.1
20cb13b 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: #46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@danielleadams danielleadams added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Apr 3, 2023
@danielleadams
Copy link
Contributor

Blocked by #46410

@anonrig anonrig mentioned this pull request Apr 5, 2023
Closed
anonrig added a commit to anonrig/node that referenced this pull request Apr 5, 2023
@anonrig
tools: fix update-ada script
ca49c5a 
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 5, 2023
@anonrig @lemire
deps: update ada to v1.0.1
fcd1058 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@anonrig anonrig added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. labels Apr 5, 2023
anonrig added a commit to anonrig/node that referenced this pull request Apr 5, 2023
@anonrig
tools: fix update-ada script
613fb91 
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 5, 2023
@anonrig @lemire
deps: update ada to v1.0.1
d2c6bbc 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
@anonrig
tools: fix update-ada script
007d23c 
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
@anonrig @lemire
deps: update ada to v1.0.1
6d59cd0 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
@anonrig
tools: fix update-ada script
0c9a8a1 
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
@anonrig @lemire
deps: update ada to v1.0.1
47e8f4e 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: nodejs#46550
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 12, 2023
@anonrig @danielleadams
tools: fix update-ada script
958da45 
PR-URL: #46550
Backport-PR-URL: #47435
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 12, 2023
@anonrig @lemire @danielleadams
deps: update ada to v1.0.1
484c4f6 
Co-authored-by: Daniel Lemire <[email protected]>
PR-URL: #46550
Backport-PR-URL: #47435
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Apr 12, 2023
@danielleadams danielleadams mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@anonrig @jasnell @richardlau @nodejs-github-bot @danielleadams @TimothyGu @cjihrig @Flarna @tniessen @aduh95