[v18.x] deps: update Openssl 3.0.8+quic #46572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: v8/v8@10.2.154.23...10.2.154.26 PR-URL: nodejs#46446 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
This updates all sources in deps/openssl/openssl by:
$ git clone [email protected]:quictls/openssl.git
$ cd openssl
$ git checkout openssl-3.0.8+quic
$ cd ../node/deps/openssl
$ rm -rf openssl
$ cp -R ../../../openssl openssl
$ rm -rf openssl/.git* openssl/.travis*
$ git add --all openssl
$ git commit openssl
nodejs-github-bot
added
dependencies
RafaelGSS
force-pushed
the
openssl-3.0.8+quic-v18.x
branch
from
7d18525 to
534af2d
Compare
|
@RafaelGSS Looks like something has gone awry with the config generation for this PR. "/Users/runner/work/node/node/deps/openssl/openssl/include/openssl/opensslconf.h:14:11: fatal error: 'openssl/configuration.h' file not found\n" +
'# include <openssl/configuration.h>\n' +
' ^~~~~~~~~~~~~~~~~~~~~~~~~\n' +
'1 error generated.\n' + |
Yes, I'm investigating it right now. Probably, it's missing some dependency in my machine during the build (fresh machine) |
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl
$ git commit
Original commit message:
rsa: add msvc intrinsic for non x64 platforms
_umul128() is x86_64 (x64) only, while __umulh() works everywhere, but
doesn't generate optimal code on x64
Refs: openssl/openssl#20244
RafaelGSS
force-pushed
the
openssl-3.0.8+quic-v18.x
branch
from
90500ca to
63ad98a
Compare
richardlau
approved these changes
Feb 13, 2023
RafaelGSS
force-pushed
the
v18.x-staging
branch
from
0f29b57 to
5e1f213
Compare
|
Landed in f0afa0b...5e0142a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated openssl dep to openssl-3.0.8 using the maintenance guide
Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html