Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: copy postject-api.h and LICENSE to the deps folder #46582

Closed
wants to merge 2 commits into from
Closed

deps: copy postject-api.h and LICENSE to the deps folder #46582

wants to merge 2 commits into from

Conversation

RaisinTen
Copy link
Contributor

Since postject-api.h gets compiled into Node.js, it makes more sense to put it in the deps directory instead of test/fixtures.

Refs: #45038 (comment)
Signed-off-by: Darshan Sen [email protected]

cc @mhdawson @nodejs/single-executable

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 9, 2023
@RaisinTen RaisinTen mentioned this pull request Feb 9, 2023
Merged
@RaisinTen
deps: copy postject-api.h and LICENSE to the deps folder
2c626f5 
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.

Refs: nodejs#45038 (comment)
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen force-pushed the deps/copy-postject-api-and-license-to-the-deps-folder branch from 54baca1 to 2c626f5 Compare February 9, 2023 06:37
@RaisinTen
Copy link
Contributor Author

RaisinTen commented Feb 9, 2023 •
edited
Loading

Although this has the needs-ci PRs that need a full CI run. label, I'd like to land this PR manually without waiting for a green Jenkins CI because nothing here is actually compiled or tested on the Jenkins CI yet.

@RaisinTen RaisinTen added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 9, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen removed the needs-ci PRs that need a full CI run. label Feb 9, 2023
ovflowd
ovflowd approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval :)

@RaisinTen RaisinTen requested a review from anonrig February 9, 2023 17:23
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2023
mhdawson
mhdawson approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTen RaisinTen removed the fast-track PRs that do not need to wait for 48 hours to land. label Feb 10, 2023
RaisinTen added a commit that referenced this pull request Feb 11, 2023
@RaisinTen
deps: copy postject-api.h and LICENSE to the deps folder
a37c083 
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.

Refs: #45038 (comment)
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46582
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RaisinTen
Copy link
Contributor Author

Landed in a37c083

@RaisinTen RaisinTen closed this Feb 11, 2023
@RaisinTen RaisinTen deleted the deps/copy-postject-api-and-license-to-the-deps-folder branch February 11, 2023 05:08
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@RaisinTen @MylesBorins
deps: copy postject-api.h and LICENSE to the deps folder
c0983cf 
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.

Refs: #45038 (comment)
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46582
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
RaisinTen added a commit to RaisinTen/node that referenced this pull request Apr 10, 2023
@RaisinTen
deps: copy postject-api.h and LICENSE to the deps folder
7a4b559 
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.

Refs: nodejs#45038 (comment)
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#46582
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RaisinTen RaisinTen mentioned this pull request Apr 10, 2023
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@RaisinTen @danielleadams
deps: copy postject-api.h and LICENSE to the deps folder
65b877d 
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.

Refs: #45038 (comment)
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #46582
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
@RaisinTen RaisinTen added the single-executable Issues and PRs related to single-executable applications label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-go tony-go tony-go approved these changes

@ovflowd ovflowd ovflowd approved these changes

@mhdawson mhdawson mhdawson approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. single-executable Issues and PRs related to single-executable applications tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RaisinTen @nodejs-github-bot @lpinca @anonrig @mhdawson @ovflowd @tony-go