Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: add __wasm32__ guards on async works #46633

Merged
merged 1 commit into from
Feb 24, 2023
Merged

node-api: add __wasm32__ guards on async works #46633

merged 1 commit into from
Feb 24, 2023

Conversation

legendecas
Copy link
Member

Threaded work napi_async_work is not available on wasm. Hide their declaration if __wasm32__ is defined.

Refs: #33597
Refs: nodejs/node-addon-api#1283

@legendecas legendecas added the node-api Issues and PRs related to the Node-API. label Feb 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 13, 2023
mhdawson
mhdawson approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49760/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49771/

@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49838/

This was referenced Feb 22, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49942/

@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49964/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit ff91fc1 into nodejs:main Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ff91fc1

@legendecas legendecas deleted the node-api/wasm branch February 24, 2023 06:12
This was referenced Feb 25, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@legendecas @targos
node-api: add __wasm32__ guards on async works
58b1f33 
PR-URL: #46633
Refs: #33597
Refs: nodejs/node-addon-api#1283
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@legendecas @danielleadams
node-api: add __wasm32__ guards on async works
331073a 
PR-URL: #46633
Refs: #33597
Refs: nodejs/node-addon-api#1283
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @nodejs-github-bot @jasnell @cjihrig @tniessen @mhdawson