Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: rename internal module declaration as internal bindings #46663

Merged
merged 1 commit into from
Feb 27, 2023
Merged

lib: rename internal module declaration as internal bindings #46663

merged 1 commit into from
Feb 27, 2023

Conversation

okmttdhr
Copy link
Contributor

@okmttdhr okmttdhr commented Feb 15, 2023 •
edited
Loading

This is a follow-up to #45551.

Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL to
NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function internalBinding
in the JS land, the term "internal binding" can be straightforward to be adopted.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 15, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 16, 2023
@okmttdhr
lib: rename internal module declaration as internal bindings
aea041b 
This is a follow-up to nodejs#45551 .

Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function internalBinding
in the JS land, the term "internal binding" can be straightforward to
be adopted.
@okmttdhr okmttdhr force-pushed the rename-internal-module-declaration branch from 30ba095 to aea041b Compare February 16, 2023 09:31
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49576/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50032/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit fadcee7 into nodejs:main Feb 27, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in fadcee7

@okmttdhr okmttdhr deleted the rename-internal-module-declaration branch February 27, 2023 08:34
targos pushed a commit that referenced this pull request Mar 13, 2023
@okmttdhr @targos
lib: rename internal module declaration as internal bindings
aae6719 
This is a follow-up to #45551 .

Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function internalBinding
in the JS land, the term "internal binding" can be straightforward to
be adopted.

PR-URL: #46663
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@okmttdhr @targos
lib: rename internal module declaration as internal bindings
4e18651 
This is a follow-up to #45551 .

Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function internalBinding
in the JS land, the term "internal binding" can be straightforward to
be adopted.

PR-URL: #46663
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@okmttdhr @danielleadams
lib: rename internal module declaration as internal bindings
06e0dd3 
This is a follow-up to #45551 .

Renaming NODE_MODULE_CONTEXT_AWARE_INTERNAL
to NODE_BINDING_CONTEXT_AWARE_INTERNAL.
As these bindings are already loaded with the function internalBinding
in the JS land, the term "internal binding" can be straightforward to
be adopted.

PR-URL: #46663
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@legendecas legendecas legendecas approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@okmttdhr @nodejs-github-bot @jasnell @lpinca @cjihrig @joyeecheung @legendecas @RaisinTen @VoltrexKeyva @aduh95