Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: enable usage of webstreams on compose() #46675

Merged
merged 12 commits into from
Feb 27, 2023
Merged

stream: enable usage of webstreams on compose() #46675

merged 12 commits into from
Feb 27, 2023

Conversation

debadree25
Copy link
Member

@debadree25 debadree25 commented Feb 15, 2023 •
edited
Loading

The final one in the series

Refs: #39316

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 15, 2023
@debadree25
Copy link
Member Author

ping @ronag

@debadree25 debadree25 force-pushed the ft/compose-webstreams branch from dce9344 to 505d884 Compare February 15, 2023 19:28
debadree25
debadree25 commented Feb 16, 2023
View reviewed changes
lib/internal/streams/compose.js
} else {
onclose = callback;
if (isNodeStream(tail)) {
destroyer(tail, err);
Copy link
Member Author

@debadree25 debadree25 Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some help is needed here, how could we destroy webstreams here? or should we even?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the question? (We can destroy web streams the question is what scenario do you specifically mean)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the pipeline encounters an error, it would call d.destroy, which in turn would destroy the last stream in the series the tail stream should the same happen for webstreams too I think we could do writableStream.abort() here.

Actually, i am a little confused why destroying the last stream is necessary 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one question remain wdyt @benjamingr ?

@debadree25 debadree25 changed the title streams: enable usage of webstreams on compose() stream: enable usage of webstreams on compose() Feb 16, 2023
@debadree25
Copy link
Member Author

Added tests and doc opening for review

@debadree25 debadree25 marked this pull request as ready for review February 16, 2023 17:12
@debadree25 debadree25 marked this pull request as draft February 16, 2023 17:16
@debadree25 debadree25 marked this pull request as ready for review February 16, 2023 18:23
ronag
ronag reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite complicated. Can you please make this as easy to review as possible, i.e. avoid any unnecessary changes and make the diff as small as possible, e.g. don't rename d to duplex.

@debadree25
Copy link
Member Author

Simplified the diff, and removed the unnecessary functions could you check @ronag

mcollina
mcollina approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

benjamingr
benjamingr approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments that are non-blocking for now but I'd like addressed

lib/internal/streams/compose.js Show resolved Hide resolved
lib/internal/streams/compose.js Outdated Show resolved Hide resolved
lib/internal/streams/compose.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@debadree25 debadree25 requested a review from ronag February 18, 2023 19:40
@github-actions github-actions bot mentioned this pull request Feb 19, 2023
Open
21 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
ronag
ronag requested changes Feb 19, 2023
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some time to review this

@debadree25
Copy link
Member Author

No problem!

@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
24 tasks
@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Open
26 tasks
@debadree25 debadree25 added stream Issues and PRs related to the stream subsystem. web streams request-ci Add this label to start a Jenkins CI on a PR. labels Feb 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50035/

mcollina
mcollina approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Feb 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 94e1f8f into nodejs:main Feb 27, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 94e1f8f

@debadree25
Copy link
Member Author

I think we can close #39316 now

implemented:

  • finished
  • pipeline
  • compose
  • addAbortSignal

debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
stream: enable usage of webstreams on compose()
7204237 
Refs: nodejs#39316
PR-URL: nodejs#46675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
stream: enable usage of webstreams on compose()
f27c29c 
Refs: nodejs#39316
PR-URL: nodejs#46675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
debadree25 added a commit to debadree25/node that referenced this pull request Feb 27, 2023
@debadree25
stream: enable usage of webstreams on compose()
8f10c66 
Refs: nodejs#39316
PR-URL: nodejs#46675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@debadree25 debadree25 mentioned this pull request Feb 27, 2023
Closed
targos pushed a commit that referenced this pull request Mar 13, 2023
@debadree25 @targos
stream: enable usage of webstreams on compose()
8c627f7 
Refs: #39316
PR-URL: #46675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@debadree25 @targos
stream: enable usage of webstreams on compose()
f886681 
Refs: #39316
PR-URL: #46675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@debadree25 @danielleadams
stream: enable usage of webstreams on compose()
dffe7d8 
Refs: #39316
PR-URL: #46675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. stream Issues and PRs related to the stream subsystem. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@debadree25 @nodejs-github-bot @mcollina @jasnell @benjamingr @ronag