Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix worker startup benchmark #46680

Merged
merged 1 commit into from
Feb 23, 2023
Merged

benchmark: fix worker startup benchmark #46680

merged 1 commit into from
Feb 23, 2023

Conversation

joyeecheung
Copy link
Member

It previously called spawnProcess in spawnWorker, which was incorrect.

@joyeecheung
benchmark: fix worker startup benchmark
34a991a 
It previously called spawnProcess in spawnWorker, which was
incorrect.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Feb 16, 2023
@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49872/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9e06ef0 into nodejs:main Feb 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9e06ef0

targos pushed a commit that referenced this pull request Mar 13, 2023
@joyeecheung @targos
benchmark: fix worker startup benchmark
9890eaa 
It previously called spawnProcess in spawnWorker, which was
incorrect.

PR-URL: #46680
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@joyeecheung @danielleadams
benchmark: fix worker startup benchmark
d7d634b 
It previously called spawnProcess in spawnWorker, which was
incorrect.

PR-URL: #46680
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @nodejs-github-bot @jasnell @lpinca @cjihrig @legendecas @anonrig