Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add trailing commas in internal/process #46687

Merged
merged 1 commit into from
Feb 18, 2023
Merged

lib: add trailing commas in internal/process #46687

merged 1 commit into from
Feb 18, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 16, 2023

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 16, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 16, 2023
@aduh95 aduh95 merged commit cafc0b2 into nodejs:main Feb 18, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 18, 2023

Landed in cafc0b2

@aduh95 aduh95 deleted the process-dangle branch February 18, 2023 17:56
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@aduh95 @MylesBorins
lib: add trailing commas in internal/process
53fe480 
PR-URL: #46687
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@aduh95 @MylesBorins
lib: add trailing commas in internal/process
fa600fe 
PR-URL: #46687
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
lib: add trailing commas in internal/process
48cd712 
PR-URL: #46687
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @MoLow @RaisinTen