Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update nghttp2 action #46700

Closed
wants to merge 2 commits into from
Closed

tools: update nghttp2 action #46700

wants to merge 2 commits into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Feb 17, 2023 •
edited
Loading

related to: nodejs/security-wg#828
Automate nghttp2 update

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 17, 2023
@RafaelGSS
Copy link
Member

cc: @nodejs/security-wg

@RafaelGSS RafaelGSS requested review from mhdawson and targos February 17, 2023 15:40
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2023
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46700
✔  Done loading data for nodejs/node/pull/46700
----------------------------------- PR info ------------------------------------
Title      tools: update nghttp2 action (#46700)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/github-action-nghttp2 -> nodejs:main
Labels     meta, author ready
Commits    2
 - tools: update nghttp2 action
 - tools: fixed path
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/46700
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tierney Cyren 
Reviewed-By: Jiawen Geng 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46700
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Tierney Cyren 
Reviewed-By: Jiawen Geng 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 17 Feb 2023 15:21:14 GMT
   ✔  Approvals: 8
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303679564
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303697086
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303782134
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46700#pullrequestreview-1303996205
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304460349
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304590430
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304604184
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46700#pullrequestreview-1304927111
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   16aacfa366..4737a20662  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 27f0c6fd8f tools: update-nghttp2 preserve config.h
 - 4737a20662 tools: update-nghttp2 preserve config.h
--------------------------------------------------------------------------------
HEAD is now at 4737a20662 tools: update-nghttp2 preserve config.h
   ✔  Reset to origin/main
- Downloading patch for 46700
From https://github.com/nodejs/node
 * branch                  refs/pull/46700/merge -> FETCH_HEAD
✔  Fetched commits as 4737a206623a..b198d2dd916d
--------------------------------------------------------------------------------
[main 5fd5ab30c7] tools: update nghttp2 action
 Author: Marco Ippolito 
 Date: Fri Feb 17 16:09:10 2023 +0100
 1 file changed, 10 insertions(+)
[main 068fc2e3e2] tools: fixed path
 Author: Marco Ippolito 
 Date: Fri Feb 17 16:29:53 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: update nghttp2 action


PR-URL: #46700

Reviewed-By: Rafael Gonzaga [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Colin Ihrig [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Tierney Cyren [email protected]

Reviewed-By: Jiawen Geng [email protected]

Reviewed-By: Michaël Zasso [email protected]

Reviewed-By: James M Snell [email protected]


[detached HEAD 3b2fcb747a] tools: update nghttp2 action

Author: Marco Ippolito [email protected]

Date: Fri Feb 17 16:09:10 2023 +0100

1 file changed, 10 insertions(+)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: fixed path


PR-URL: #46700

Reviewed-By: Rafael Gonzaga [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Colin Ihrig [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Tierney Cyren [email protected]

Reviewed-By: Jiawen Geng [email protected]

Reviewed-By: Michaël Zasso [email protected]

Reviewed-By: James M Snell [email protected]


[detached HEAD fedb03d3d5] tools: fixed path

Author: Marco Ippolito [email protected]

Date: Fri Feb 17 16:29:53 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/4235128104

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4737a20...f331424

nodejs-github-bot pushed a commit that referenced this pull request Feb 21, 2023
@marco-ippolito @nodejs-github-bot
tools: update nghttp2 action
3fe0892 
PR-URL: #46700
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 21, 2023
@marco-ippolito @nodejs-github-bot
tools: fixed path
f331424 
PR-URL: #46700
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Feb 21, 2023
Closed
23 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
@marco-ippolito @targos
tools: update nghttp2 action
a560a78 
PR-URL: #46700
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 13, 2023
@marco-ippolito @targos
tools: fixed path
dd40034 
PR-URL: #46700
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito @danielleadams
tools: update nghttp2 action
15b0e8b 
PR-URL: #46700
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito @danielleadams
tools: fixed path
8fd1760 
PR-URL: #46700
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

@jasnell jasnell jasnell approved these changes

@mhdawson mhdawson Awaiting requested review from mhdawson

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@marco-ippolito @nodejs-github-bot @RafaelGSS @jasnell @bnb @lpinca @anonrig @targos @cjihrig @gengjiawen