Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v19.x backport] test_runner: flatten TAP output when running using --test #46722

Closed
wants to merge 1 commit into from
Closed

[v19.x backport] test_runner: flatten TAP output when running using --test #46722

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Feb 18, 2023

as written here, this pr includes some earlier commits it depends on

@MoLow MoLow requested a review from MylesBorins February 18, 2023 21:48
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v19.x labels Feb 18, 2023
@MoLow MoLow force-pushed the v19-backport-test-runner-flatten-tap branch from 5b64b4b to 1f19c4b Compare February 19, 2023 06:41
@MoLow
test_runner: flatten TAP output when running using --test
01b9515 
PR-URL: nodejs#46440
Fixes: nodejs#45833
Refs: nodejs#45833
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow MoLow force-pushed the v19-backport-test-runner-flatten-tap branch from 1f19c4b to 01b9515 Compare February 25, 2023 21:08
@MoLow
Copy link
Member Author

MoLow commented Feb 25, 2023

CC @nodejs/backporters @nodejs/releasers I have made sure all other test runner related PR's land clearly on top of this

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50003/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50013/

This was referenced Feb 27, 2023
Open
Open
@targos
Copy link
Member

targos commented Mar 13, 2023

The original commit landed cleanly in the end

@targos targos closed this Mar 13, 2023
@MoLow
Copy link
Member Author

MoLow commented Mar 13, 2023

thanks

@MoLow MoLow deleted the v19-backport-test-runner-flatten-tap branch March 13, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MoLow @nodejs-github-bot @targos @benjamingr