Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: simplify and improve url formatting #46736

Merged
merged 1 commit into from
Feb 24, 2023
Merged

url: simplify and improve url formatting #46736

merged 1 commit into from
Feb 24, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 19, 2023 •
edited
Loading

This pull request separates the logic of kFormat and URL and moves the logic to C++.

Quick summary:

  • Move Url.format implementation to C++ where it directly calls Ada. This is done to avoid having any URL logic inside Node.js
  • Call search setter whenever searchParams is changed, instead of calculating href on the JS layer. This was done to remove any URL logic inside Node.js.
  • Remove kFormat since it isn't used anymore after step 1 and 2.
  • Remove hasOpaquePath and hasHost from URL, since it was only needed for kFormat and searchParams setter.
  • Ise ToStringView() and ToString() methods that @addaleax recommended.

cc @nodejs/url @nodejs/cpp-reviewers

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 19, 2023
@anonrig anonrig force-pushed the improve-url-parsing branch from 2e032a0 to 4c6bdff Compare February 19, 2023 19:13
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49740/

addaleax
addaleax reviewed Feb 19, 2023
View reviewed changes
src/node_url.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49749/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49752/

@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49755/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49765/

@RaisinTen
Copy link
Contributor

Is this for better performance?

@anonrig
Copy link
Member Author

anonrig commented Feb 20, 2023

Is this for better performance?

Not for this specifically, but I'm preparing for the new Ada changes where we will focus on enabling node.js-specific APIs to improve the performance. This is mainly for removing the URL parsing logic from Node.js core, and moving it to C++/Ada.

@joyeecheung joyeecheung mentioned this pull request Feb 20, 2023
Closed
@anonrig anonrig added the review wanted PRs that need reviews. label Feb 20, 2023
@anonrig anonrig requested review from jasnell and TimothyGu February 20, 2023 17:16
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49799/

@anonrig anonrig requested a review from addaleax February 20, 2023 18:52
@anonrig anonrig force-pushed the improve-url-parsing branch from 4c6bdff to c8f6c5a Compare February 20, 2023 23:03
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49808/

@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49811/

addaleax
addaleax reviewed Feb 21, 2023
View reviewed changes
lib/url.js Outdated Show resolved Hide resolved
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8073392 into nodejs:main Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 8073392

@anonrig anonrig deleted the improve-url-parsing branch February 24, 2023 22:35
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Open
28 tasks
@tniessen tniessen mentioned this pull request Mar 2, 2023
Closed
targos pushed a commit that referenced this pull request Mar 13, 2023
@anonrig @targos
url: simplify and improve url formatting
5a3ad87 
PR-URL: #46736
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams
Copy link
Contributor

@anonrig this broke the build when landing in v18.x. Do you mind creating a backport PR?

@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Apr 3, 2023
This was referenced Apr 3, 2023
Merged
Merged
Merged
anonrig added a commit to anonrig/node that referenced this pull request Apr 5, 2023
@anonrig
url: simplify and improve url formatting
202e5f9 
PR-URL: nodejs#46736
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@anonrig anonrig mentioned this pull request Apr 5, 2023
Closed
@anonrig anonrig added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Apr 5, 2023
@anonrig
Copy link
Member Author

anonrig commented Apr 5, 2023

This depends on #46723

@anonrig anonrig added backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Apr 5, 2023
anonrig added a commit to anonrig/node that referenced this pull request Apr 6, 2023
@anonrig
url: simplify and improve url formatting
8a38aed 
PR-URL: nodejs#46736
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@anonrig anonrig added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Apr 6, 2023
anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
@anonrig
url: simplify and improve url formatting
ccb5b4f 
PR-URL: nodejs#46736
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
anonrig added a commit to anonrig/node that referenced this pull request Apr 11, 2023
@anonrig
url: simplify and improve url formatting
aae4141 
PR-URL: nodejs#46736
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 12, 2023
@anonrig @danielleadams
url: simplify and improve url formatting
a39dd37 
PR-URL: #46736
Backport-PR-URL: #47435
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Apr 12, 2023
@danielleadams danielleadams mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @RaisinTen @danielleadams @jasnell @addaleax @TimothyGu