-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: cleanup WPT setup files, update WPT fixtures, update expectations #46753
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not easy to review it right now. I recommend splitting it into multiple commits.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not bad
I'm going to pass on this change, it's a big one and i'll rather do them in smaller steps that are backportable at least to v18.x |
test/wpt/test-{wptmodule}.js
setup files, common setups are pushed to the WPT Runner, lint rule is updated to not need to require('../common')There is one new acknowledged failure that I think might be a bug (
Reading Blob.stream() with BYOB reader
intest/wpt/test-blob.js
cc @nodejs/streams if you want to follow up on that failing test.