Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: fix unhandled exception aborting a closed udp socket #46770

Merged
merged 1 commit into from
Feb 25, 2023
Merged

dgram: fix unhandled exception aborting a closed udp socket #46770

merged 1 commit into from
Feb 25, 2023

Conversation

vramana
Copy link
Contributor

@vramana vramana commented Feb 22, 2023

Fixes: #46750

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Feb 22, 2023
@ShogunPanda
Copy link
Contributor

Can you please add a test for this?

@vramana
Copy link
Contributor Author

vramana commented Feb 22, 2023

@ShogunPanda Does this suffice?

mcollina
mcollina approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cjihrig
cjihrig approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@ShogunPanda
Copy link
Contributor

@ShogunPanda Does this suffice?

Absolutely, thanks!

LGTM!

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49988/

@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Open
28 tasks
@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 65d2a42 into nodejs:main Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 65d2a42

@vramana vramana deleted the fix-dgram branch February 25, 2023 16:13
@github-actions github-actions bot mentioned this pull request Feb 26, 2023
Open
15 tasks
This was referenced Feb 27, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@vramana @targos
dgram: fix unhandled exception aborting a closed udp socket
247dfb7 
Fixes: #46750
PR-URL: #46770
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@vramana @danielleadams
dgram: fix unhandled exception aborting a closed udp socket
8646b06 
Fixes: #46750
PR-URL: #46770
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing UDP socket with abort signal can lead to uncaught exception
9 participants
@vramana @nodejs-github-bot @ShogunPanda @mcollina @jasnell @cjihrig @BridgeAR @debadree25 @theanarkh