test: fix test-net-connect-reset-until-connected

[batrla]

Fixes a race condition in test that causes the test to randomly timeout on Solaris 11.4, SmartOS and potentially also FreeBSD. TCP server starts listening and waits for client connection. The client resets the connection using conn.resetAndDestroy() and server is expected to see an error. The call to resetAndDestroy() is asynchronous is subject to race with earlier net.createConnection(). If effect of resetAndDestroy() occurs before server's listening socket accepts the connection, the test hangs. Test hang occurs since 'connection' event is never emitted as underlying function call to accept(3C) failed returning ECONNABORTED. The accept() failure is result of premature close(2) on client's file descriptor. Premature close(2) is result of too fast conn.resetAndDestroy().

The fix is to put a synchronization barrier that resets the connection only after it is established on both server and client side.

Below is a little bit more about the root cause. I show positive (test works) and negative (when test hangs) scenarios. The output contains only relevant system / library calls that were collected using truss(1). Without the fix the test randomly hangs. With the fix the test completes thousands of runs without single issue.

Race condition scenario:

connect(23, 0x7FFFBFFF7F10, 32, SOV_XPG4_2)Err#150 EINPROGRESS
^ client socket connects to server
close(23)= 0
^ client closes the socket too early
accept(21, 0x00000000, 0x00000000, SOV_DEFAULT)Err#130 ECONNABORTED
accept(21, 0x00000000, 0x00000000, SOV_DEFAULT)Err#11 EAGAIN
^ accept on listening socket fails
... test hangs and times out...

Working (good) scenario:

connect(23, 0x7FFFBFFF7F00, 32, SOV_XPG4_2)Err#150 EINPROGRESS
^ client socket connects to server
accept(21, 0x00000000, 0x00000000, SOV_DEFAULT)= 24
^ server accepts client connection on listening socket
close(23)= 0
^ client socket closes
read(24, 0x046B6010, 65536)Err#131 ECONNRESET
^ test gets so much wanted error while reading on accepted FD
close(24)= 0
^ accepted FD closes
... test completes, passes ...

Fixes: #43446

[batrla]

Fixed lint errors and cleaned up commit message.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49929/

[nodejs-github-bot]

Landed in 21fcfcd