Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix linter message when using global DOMException #46822

Merged
merged 1 commit into from
Feb 26, 2023
Merged

tools: fix linter message when using global DOMException #46822

merged 1 commit into from
Feb 26, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 24, 2023

Refs:

node/lib/internal/util.js

Lines 601 to 610 in 757c104

let _DOMException;
const lazyDOMExceptionClass = () => {
_DOMException ??= internalBinding('messaging').DOMException;
return _DOMException;
};
const lazyDOMException = hideStackFrames((message, name) => {
_DOMException ??= internalBinding('messaging').DOMException;
return new _DOMException(message, name);
});

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 24, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 24, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2023
@aduh95 aduh95 merged commit 55dd283 into nodejs:main Feb 26, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 26, 2023

Landed in 55dd283

@aduh95 aduh95 deleted the dom-exception-linter-error branch February 26, 2023 17:44
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
tools: fix linter message when using global DOMException
ffcd301 
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: #46822
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
tools: fix linter message when using global DOMException
f558797 
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: #46822
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
tools: fix linter message when using global DOMException
fff3186 
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: #46822
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@debadree25 debadree25 debadree25 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @apapirovski @jasnell @cjihrig @debadree25 @ZYSzys @nodejs-github-bot