Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update simdutf to 3.2.2 #46841

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of simdutf to 3.2.2.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 26, 2023
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is suspiciously small, is the workflow working as expected? 🤔

@anonrig
Copy link
Member

anonrig commented Feb 26, 2023

The diff is suspiciously small, is the workflow working as expected? 🤔

Yes, the change was related to performance counters, but its not included in the singleheader deployment of simdutf. cc @lemire

@lemire
Copy link
Member

lemire commented Feb 26, 2023

Right. It is a version bump that fixes a very specific issue that affected brew maintainers.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2023
@anonrig anonrig requested a review from aduh95 February 26, 2023 20:17
@lpinca
Copy link
Member

lpinca commented Mar 1, 2023

I think we can skip this update, no? It's only noise.

I guess it will be picked up again when the workflow runs.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 55c944e into main Mar 1, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-simdutf branch March 1, 2023 21:01
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 55c944e

targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46841
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46841
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46841
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants