Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit crypto examples for consistency (nitpick) #46847

Closed
wants to merge 2 commits into from
Closed

doc: edit crypto examples for consistency (nitpick) #46847

wants to merge 2 commits into from

Conversation

jakecastelli
Copy link
Member

This PR is just a nitpick while reading the crypto doc

  • Most of the examples are using ES6 module destructing import syntax, this PR changed the one that is not follow the convention.
  • Sort the import order

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 26, 2023
Trott
Trott approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Oops, never mind. The individual commits are worded correctly.

@Trott Trott added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 27, 2023
@jakecastelli jakecastelli changed the title doc: crypto example nitpick doc: edit crypto examples for consistency (nitpick) Feb 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7a37829...9562c20

nodejs-github-bot pushed a commit that referenced this pull request Feb 28, 2023
@jakecastelli @nodejs-github-bot
doc: use destructing import
d2d95a3 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 28, 2023
@jakecastelli @nodejs-github-bot
doc: sort import order
9562c20 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 13, 2023
@jakecastelli @targos
doc: use destructing import
152cb4b 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 13, 2023
@jakecastelli @targos
doc: sort import order
4a098e8 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@jakecastelli @targos
doc: use destructing import
9d2532e 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@jakecastelli @targos
doc: sort import order
c0b6413 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jakecastelli @danielleadams
doc: use destructing import
6e03499 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jakecastelli @danielleadams
doc: sort import order
810d393 
PR-URL: #46847
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakecastelli @nodejs-github-bot @apapirovski @Trott @lpinca