Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add trailing commas to all public core modules #46848

Merged
merged 1 commit into from
Feb 28, 2023
Merged

lib: add trailing commas to all public core modules #46848

merged 1 commit into from
Feb 28, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 26, 2023

Once this has landed, the next step would be to remove the overrides and have the rule applied on the whole lib folder.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/streams
  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 26, 2023
MoLow
MoLow reviewed Feb 26, 2023
View reviewed changes
lib/.eslintrc.yaml
- ./fs.js
- ./internal/assert.js
- ./internal/child_process.js
- ./*.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming, this is not recursive, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, there are still 247 missing trailing commas files inside subdirs of lib/internal (my understanding is that * matches any char but the path separator, and ** would match any char including the path separator).

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 26, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2023
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@aduh95
lib: add trailing commas to all public core modules
9dbb162 
PR-URL: nodejs#46848
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 28, 2023

Landed in 9dbb162

@aduh95 aduh95 merged commit 9dbb162 into nodejs:main Feb 28, 2023
@aduh95 aduh95 deleted the public-dangle branch February 28, 2023 11:12
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
lib: add trailing commas to all public core modules
0b7d2a4 
PR-URL: #46848
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
lib: add trailing commas to all public core modules
5c7fc92 
PR-URL: #46848
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
lib: add trailing commas to all public core modules
0f33bb0 
PR-URL: #46848
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@debadree25 debadree25 debadree25 approved these changes

@trivikr trivikr trivikr approved these changes

@MoLow MoLow MoLow approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@benjamingr benjamingr benjamingr approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aduh95 @nodejs-github-bot @apapirovski @benjamingr @gengjiawen @MoLow @trivikr @debadree25 @ZYSzys @RafaelGSS