Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: remove lastInputPreview conditional check #46857

Merged
merged 1 commit into from
Mar 1, 2023
Merged

repl: remove lastInputPreview conditional check #46857

merged 1 commit into from
Mar 1, 2023

Conversation

jenthone
Copy link
Contributor

@jenthone jenthone commented Feb 27, 2023 •
edited
Loading

Fix #37585

Phenomenon: #37585 (comment)

ChromeDevTools doesn’t show a preview identical to the input as well

ChromeDevTools

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Feb 27, 2023
@jenthone jenthone marked this pull request as ready for review February 28, 2023 02:00
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@cola119
Copy link
Member

cola119 commented Feb 28, 2023

cc @nodejs/repl @BridgeAR

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50084/

BridgeAR
BridgeAR approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50096/

@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit d0608c2 into nodejs:main Mar 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d0608c2

@jenthone jenthone deleted the fix/prevent_identical_input branch March 1, 2023 15:46
targos pushed a commit that referenced this pull request Mar 13, 2023
@jenthone @targos
repl: remove lastInputPreview conditional check
e994fd4 
PR-URL: #46857
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@jenthone @targos
repl: remove lastInputPreview conditional check
56dbb15 
PR-URL: #46857
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jenthone @danielleadams
repl: remove lastInputPreview conditional check
34ba230 
PR-URL: #46857
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cola119 cola119 cola119 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange repl eager-eval behavior
4 participants
@jenthone @cola119 @nodejs-github-bot @BridgeAR