Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-tls-autoselectfamily-servername to test/internet #47029

Merged
merged 2 commits into from
Mar 11, 2023
Merged

test: move test-tls-autoselectfamily-servername to test/internet #47029

merged 2 commits into from
Mar 11, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 9, 2023

And switch from google.com to nodejs.org.

@aduh95
test: move test-tls-autoselectfamily-servername to test/internet
7331c24 
And switch from `google.com` to `nodejs.org`.
@aduh95 aduh95 requested a review from ShogunPanda March 9, 2023 13:48
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 9, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 403 Forbidden
https://github.com/nodejs/node/actions/runs/4375426438

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
ShogunPanda
ShogunPanda approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95
Copy link
Contributor Author

aduh95 commented Mar 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50298/ 💛

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 03fd5ae into nodejs:main Mar 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 03fd5ae

targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
test: move test-tls-autoselectfamily-servername to test/internet
5be908d 
And switch from `google.com` to `nodejs.org`.

PR-URL: #47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
test: move test-tls-autoselectfamily-servername to test/internet
11509a4 
And switch from `google.com` to `nodejs.org`.

PR-URL: #47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
test: move test-tls-autoselectfamily-servername to test/internet
ba340a0 
And switch from `google.com` to `nodejs.org`.

PR-URL: #47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
@mhdawson mhdawson mentioned this pull request Jul 27, 2023
Merged
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 4, 2023
@aduh95 @mhdawson
test: move test-tls-autoselectfamily-servername to test/internet
26d38d0 
And switch from `google.com` to `nodejs.org`.

PR-URL: nodejs#47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@mhdawson mhdawson mentioned this pull request Aug 4, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Aug 14, 2023
@aduh95 @ruyadorno
test: move test-tls-autoselectfamily-servername to test/internet
a9441de 
And switch from `google.com` to `nodejs.org`.

PR-URL: #47029
Backport-PR-URL: #49016
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. and removed needs-ci PRs that need a full CI run. backported-to-v18.x PRs backported to the v18.x-staging branch. labels Aug 14, 2023
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
@aduh95 @mhdawson
test: move test-tls-autoselectfamily-servername to test/internet
5088d3e 
And switch from `google.com` to `nodejs.org`.

PR-URL: nodejs#47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
@aduh95 @mhdawson
test: move test-tls-autoselectfamily-servername to test/internet
918f2a8 
And switch from `google.com` to `nodejs.org`.

PR-URL: nodejs#47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@mhdawson mhdawson mentioned this pull request Aug 15, 2023
Closed
@mhdawson
Copy link
Member

Backport to 18.x PR (second try) - #49183

@mhdawson mhdawson added the backport-open-v18.x Indicate that the PR has an open backport. label Aug 15, 2023
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
@aduh95 @mhdawson
test: move test-tls-autoselectfamily-servername to test/internet
bc475f5 
And switch from `google.com` to `nodejs.org`.

PR-URL: nodejs#47029
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 17, 2023
@aduh95 @ruyadorno
test: move test-tls-autoselectfamily-servername to test/internet
6de7aa1 
And switch from `google.com` to `nodejs.org`.

PR-URL: #47029
Backport-PR-URL: #49183
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. backport-open-v18.x Indicate that the PR has an open backport. labels Aug 17, 2023
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aduh95 @nodejs-github-bot @mhdawson @ShogunPanda @lpinca @cjihrig @tniessen @richardlau @MoLow @ruyadorno