errors: use determineSpecificType in more error messages
#49580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
anonrig
approved these changes
Sep 10, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
KhafraDev
approved these changes
Sep 10, 2023
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d3e0331 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49580 Fixes: #49576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49580 Fixes: nodejs#49576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
aduh95
added a commit
that referenced
this pull request
Nov 2, 2024
PR-URL: #49580 Fixes: #49576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
aduh95
added
backported-to-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it would have say something like
Expected a … to be returned for the "…" from the function but got an instance of String., and with this PR it would say the more useful and more correctExpected a … to be returned for the "…" from the function but got type string ('the input string').Fixes: #49576