test: reduce the number of requests and parsers #50240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Oct 18, 2023
github-actions
bot
removed
the
request-ci
H4ad
approved these changes
Oct 18, 2023
H4ad
added
the
author ready
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs#50228 (comment)
lpinca
force-pushed
the
reduce/free-list-size
branch
from
1e3b34e
to
b5659fb
Compare
github-actions
bot
removed
the
request-ci
StefanStojanovic
approved these changes
Oct 18, 2023
25 tasks
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Oct 19, 2023
anonrig
added
the
commit-queue
|
Updated description with the fixes prefix to the flaky issue. Thank you @lpinca |
20 tasks
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0345ea5 |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Fixes: #49564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs#50228 (comment) PR-URL: nodejs#50240 Fixes: nodejs#49564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Fixes: #49564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Apr 17, 2024
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Backport-PR-URL: #52384 Fixes: #49564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
lpinca
added
backported-to-v18.x
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs/node#50228 (comment) PR-URL: nodejs/node#50240 Fixes: nodejs/node#49564 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50.
Fixes: #49564
Refs: #50228 (comment)