Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: improve macOS notarization process output readability #50389

Merged
merged 2 commits into from
Nov 1, 2023
Merged

tools: improve macOS notarization process output readability #50389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc2689
tools: improve macOS notarization process output readability
UlisesGascon Oct 25, 2023
7021cc4
fix: remove old variable reference
UlisesGascon Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions tools/osx-notarize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,19 @@ fi
# Submit the package for notarization
# TODO(@ulisesGascon): refactor to use --keychain-profile
# when https://github.com/nodejs/build/issues/3385#issuecomment-1729281269 is ready
notarization_output=$(
xcrun notarytool submit \
--apple-id "$NOTARIZATION_ID" \
--password "$NOTARIZATION_PASSWORD" \
--team-id "$NOTARIZATION_TEAM_ID" \
--wait \
"node-$pkgid.pkg" 2>&1
)
echo "Submitting node-$pkgid.pkg for notarization..."

xcrun notarytool submit \
--apple-id "$NOTARIZATION_ID" \
--password "$NOTARIZATION_PASSWORD" \
--team-id "$NOTARIZATION_TEAM_ID" \
--wait \
"node-$pkgid.pkg"

if [ $? -eq 0 ]; then
# Extract the operation ID from the output
operation_id=$(echo "$notarization_output" | awk '/RequestUUID/ {print $NF}')
echo "Notarization submitted. Operation ID: $operation_id"
echo "Notarization node-$pkgid.pkg submitted successfully."
exit 0
else
echo "Notarization failed. Error: $notarization_output"
echo "Notarization node-$pkgid.pkg failed. Error: $notarization_output"
UlisesGascon marked this conversation as resolved.
Show resolved Hide resolved
exit 1
fi

Loading