streams: fix fd is null when calling clearBuffer #50994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Resolved. PTAL |
rluvaton
reviewed
Dec 3, 2023
Comment on lines
18
to
28
| fileWriteStream.on('finish', () => { | ||
| const writtenData = fs.readFileSync(filepath, 'utf8'); | ||
| assert.strictEqual(writtenData, data); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| fileWriteStream.on('finish', () => { | |
| const writtenData = fs.readFileSync(filepath, 'utf8'); | |
| assert.strictEqual(writtenData, data); | |
| }); | |
| fileWriteStream.on('finish', common.mustCall(() => { | |
| const writtenData = fs.readFileSync(filepath, 'utf8'); | |
| assert.strictEqual(writtenData, data); | |
| })); |
ronag
reviewed
Dec 3, 2023
lib/internal/streams/writable.js
Outdated
Comment on lines
736
to
737
| if ((state[kState] & (kDestroyed | kBufferProcessing | kCorked | kBuffered)) !== kBuffered || | ||
| (state[kState] & (kDestroyed | kBufferProcessing | kCorked | kConstructed)) !== kConstructed) { |
There was a problem hiding this comment.
Suggested change
| if ((state[kState] & (kDestroyed | kBufferProcessing | kCorked | kBuffered)) !== kBuffered || | |
| (state[kState] & (kDestroyed | kBufferProcessing | kCorked | kConstructed)) !== kConstructed) { | |
| if ((state[kState] & (kDestroyed | kBufferProcessing | kCorked | kBuffered | kConstructed)) !== (kBuffered | kConstructed)) { |
benjamingr
approved these changes
Dec 3, 2023
|
Resolved |
github-actions
bot
removed
the
request-ci
rluvaton
approved these changes
Dec 5, 2023
ronag
approved these changes
Dec 6, 2023
rluvaton
added
author ready
github-actions
bot
removed
the
request-ci
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 639c366 |
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #50994 Fixes: #50979 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
|
@mcollina Is this already in the latest release? I am still getting the error. |
|
this should be in v21.5.0. |
|
Thanks. 21 works. 20 doesn't but isn't a problem as I could simply update to 21. |
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50994 Fixes: #50979 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50979