-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add deprecation notice to dirent.path
#51059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-track has been requested by @aduh95. Please 👍 to approve. |
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
fs
Issues and PRs related to the fs subsystem / file system.
labels
Dec 5, 2023
debadree25
approved these changes
Dec 5, 2023
debadree25
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 5, 2023
lpinca
approved these changes
Dec 5, 2023
MoLow
approved these changes
Dec 5, 2023
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 5, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 5, 2023
Landed in a49b77b |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Dec 5, 2023
Refs: nodejs#51020 PR-URL: nodejs#51059 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
Refs: #51020 PR-URL: #51059 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 18, 2024
Refs: #51020 PR-URL: #51059 Backport-PR-URL: #51021 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> PR-URL: #50976
richardlau
added
the
backported-to-v18.x
PRs backported to the v18.x-staging branch.
label
Mar 18, 2024
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Refs: #51020 PR-URL: #51059 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v18.x
PRs backported to the v18.x-staging branch.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
fs
Issues and PRs related to the fs subsystem / file system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we forgot about updating
fs.md
when working on #51020