test_runner: do not invoke after hook when test is empty #51389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jan 6, 2024
Comment on lines
+6
to
+10
| test('test', async (t) => { | ||
| t.after(common.mustNotCall(() => { | ||
| t.fail('should not run'); | ||
| })); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| test('test', async (t) => { | |
| t.after(common.mustNotCall(() => { | |
| t.fail('should not run'); | |
| })); | |
| }); | |
| test('test', (t) => { | |
| t.after(common.mustNotCall()); | |
| }); |
github-actions
bot
removed
the
request-ci
marco-ippolito
added
the
author ready
atlowChemi
approved these changes
Jan 7, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a53fd95 |
marco-ippolito
added a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51389 Fixes: nodejs#51371 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51389 Fixes: nodejs#51371 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51389 Fixes: #51371 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Merged
richardlau
added
dont-land-on-v18.x
|
This is being reverted in #51998 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Notable changes: This release reverts nodejs#51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: nodejs#52002
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
Notable changes: This release reverts nodejs#51389, which landed in Node.js 21.7.0. It is a documented feature that `t.after()` hooks are run even if a test has no subtests. The hook can be used to clean up the test itself. PR-URL: nodejs#52002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51371
(recreated because apparently if you force push on a closed PR it cannot be reopened)