src: terminate correctly double-quote in env variable #51510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
marco-ippolito
force-pushed
the
env/dotenv-edge-case
branch
from
49deed2
to
52016f8
Compare
marco-ippolito
changed the title
marco-ippolito
force-pushed
the
env/dotenv-edge-case
branch
from
52016f8
to
11e15b1
Compare
anonrig
approved these changes
Jan 18, 2024
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
debadree25
approved these changes
Jan 18, 2024
debadree25
added
the
author ready
anonrig
added
the
commit-queue
benjamingr
approved these changes
Jan 18, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 880c90c |
marco-ippolito
added a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
PR-URL: nodejs#51510 Fixes: nodejs#51508 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51510 Fixes: #51508 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
marco-ippolito
added a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
PR-URL: nodejs#51510 Fixes: nodejs#51508 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51510 Fixes: #51508 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51510 Fixes: #51508 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51508