Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-fs-rmdir-recursive flaky designation #51566

Merged
merged 1 commit into from
Feb 1, 2024
Merged

test: remove test-fs-rmdir-recursive flaky designation #51566

merged 1 commit into from
Feb 1, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 25, 2024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 25, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56914/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56944/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56963/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56991/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56995/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit a7eb72d into nodejs:main Feb 1, 2024
62 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a7eb72d

@lpinca lpinca deleted the remove/flaky-designation branch February 1, 2024 20:25
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@lpinca @rdw-msft
test: remove test-fs-rmdir-recursive flaky designation
e434e28 
Refs: nodejs#41201 (comment)
PR-URL: nodejs#51566
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Feb 15, 2024
@lpinca @targos
test: remove test-fs-rmdir-recursive flaky designation
c820166 
Refs: #41201 (comment)
PR-URL: #51566
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@lpinca @marco-ippolito
test: remove test-fs-rmdir-recursive flaky designation
ee9f398 
Refs: nodejs#41201 (comment)
PR-URL: nodejs#51566
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
test: remove test-fs-rmdir-recursive flaky designation
48fb10d 
Refs: #41201 (comment)
PR-URL: #51566
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
test: remove test-fs-rmdir-recursive flaky designation
bca6dcc 
Refs: #41201 (comment)
PR-URL: #51566
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinca @nodejs-github-bot @anonrig @MoLow @marco-ippolito