doc: updates for better json generating #51592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Semigradsky
force-pushed
the
update-docs
branch
from
8566f41
to
fbf9231
Compare
|
@aduh95 This looks fine to me in general. Do we have any tool that would be broken by this? |
atlowChemi
approved these changes
Jan 29, 2024
aduh95
reviewed
Jan 29, 2024
lpinca
approved these changes
Jan 30, 2024
aduh95
reviewed
Jan 31, 2024
Semigradsky
force-pushed
the
update-docs
branch
from
5fcf923
to
2e80968
Compare
panva
approved these changes
Feb 3, 2024
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bf39716 |
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51592 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 20, 2024
PR-URL: nodejs#51592 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51592 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51592 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. for
tracker.calls([fn][, exact])fromdoc/api/assert.mdwe currently have:The
return.descdoesn't explain return type.So I made a change: