v8: implement v8.queryObjects() for memory leak regression testing #51927

joyeecheung · 2024-02-29T15:55:05Z

This is similar to the queryObjects() console API provided by the Chromium DevTools console. It can be used to search for objects that have the matching constructor on its prototype chain in the heap after a full garbage collection, which can be useful for memory leak regression tests.
To avoid surprising results, users should avoid using this API on constructors whose implementation they don't control, or on constructors that can be invoked by other parties in the application.

To avoid accidental leaks, this API does not return raw references to the objects found. By default, it returns the count of the objects found. If options.format is 'summary', it returns an array containing brief string representations for each object. The visibility provided in this API is similar to what the heap snapshot provides, while users can save the cost of serialization and parsing and directly filer the target objects during the search.

We have been using this API internally for the test suite, which has been more stable than any other leak regression testing strategies in the CI. With a public implementation we can now use the public API instead.

const { queryObjects } = require('node:v8');
class A { foo = 'bar'; }
console.log(queryObjects(A)); // 0
let a = new A();
console.log(queryObjects(A)); // 1
// [ "A { foo: 'bar' }" ]
console.log(queryObjects(A, { format: 'summary' }));

// Release the object.
a = null;
// Search again. queryObjects() includes a full garbage collection
// so a should disappear.
console.log(queryObjects(A)); // 0

class B extends A { bar = 'qux'; }
// The child class B's prototype has A's prototype on its prototype chain
// so the prototype object shows up too.
console.log(queryObjects(A, { format: 'summary' })); // [ A {}' ]

nodejs-github-bot · 2024-02-29T15:55:11Z

Review requested:

@nodejs/gyp

joyeecheung · 2024-02-29T16:00:00Z

doc/api/v8.md

+
+> Stability: 1.1 - Active development
+
+* `ctor` {Function} The constructor that can be used to search on the


This currently takes a Function to match the Chromium DevTools console API, though IMO it would also be useful to offer a complementary API that allows users to register an object for filtering, and then return the registered objects in v8.queryObjects - this can be implemented based on e.g. symbols. It's worth noting that the operations allowed in the filter in the V8 API can be quite limited (I've seen crashes before when I tried to use a symbol-based approach when I was working on #50572), so for this PR I think we should just implement what Chromium supports - prototype chain walking as a filter, which is more guaranteed to be safe.

This is similar to the `queryObjects()` console API provided by the Chromium DevTools console. It can be used to search for objects that have the matching constructor on its prototype chain in the entire heap, which can be useful for memory leak regression tests. To avoid surprising results, users should avoid using this API on constructors whose implementation they don't control, or on constructors that can be invoked by other parties in the application. To avoid accidental leaks, this API does not return raw references to the objects found. By default, it returns the count of the objects found. If `options.format` is `'summary'`, it returns an array containing brief string representations for each object. The visibility provided in this API is similar to what the heap snapshot provides, while users can save the cost of serialization and parsing and directly filer the target objects during the search. We have been using this API internally for the test suite, which has been more stable than any other leak regression testing strategies in the CI. With a public implementation we can now use the public API instead.

joyeecheung · 2024-02-29T16:23:20Z

cc @nodejs/diagnostics

github-actions · 2024-02-29T16:30:54Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @joyeecheung.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

H4ad

Incredibly useful addition!

nodejs-github-bot · 2024-02-29T19:15:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57512/

H4ad · 2024-02-29T19:22:09Z

Do you think we can create an API similar to query the shallow/retained size of an object? (at runtime), I know we can get that value from heap snapshot but I thought we could introduce more APIs to query information about memory at runtime.

joyeecheung · 2024-02-29T19:40:21Z

To calculate those it would require building a dominator tree on a full capture of the heap. That would be quite complex and it's probably still better to implement that as external tooling unless V8 is willing to implement it itself (currently this is done by the Chromium DevTools, and I guess it is a separation they would stick to...)

H4ad · 2024-02-29T20:00:57Z

Oh, got it, I thought the v8 already had an API to calculate that inside HeapProfiler.

Also, I was reading the source code of QueryObjects, and looks like that method triggers GC, should we expose this method only via --expose-gc?

joyeecheung · 2024-02-29T21:35:22Z

I don't think so, it triggers the same kind of GC that heap snapshot triggers, and we never require --expose-gc for v8.getHeapSnapshot() and friends (and, the GC from --expose-gc is different from the GC triggered by this and heap snapshots, mixing the two would be a mistake IMO).

Qard

Minor nit but otherwise LGTM.

doc/api/v8.md

…ting Co-authored-by: Stephen Belanger <[email protected]>

RafaelGSS

LGTM.

nodejs-github-bot · 2024-03-02T16:25:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57550/

naugtur · 2024-03-02T20:03:49Z

Very cool!

nodejs-github-bot · 2024-03-02T22:11:31Z

Landed in 7f2d61f

This is similar to the `queryObjects()` console API provided by the Chromium DevTools console. It can be used to search for objects that have the matching constructor on its prototype chain in the entire heap, which can be useful for memory leak regression tests. To avoid surprising results, users should avoid using this API on constructors whose implementation they don't control, or on constructors that can be invoked by other parties in the application. To avoid accidental leaks, this API does not return raw references to the objects found. By default, it returns the count of the objects found. If `options.format` is `'summary'`, it returns an array containing brief string representations for each object. The visibility provided in this API is similar to what the heap snapshot provides, while users can save the cost of serialization and parsing and directly filer the target objects during the search. We have been using this API internally for the test suite, which has been more stable than any other leak regression testing strategies in the CI. With a public implementation we can now use the public API instead. PR-URL: nodejs#51927 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

This is similar to the `queryObjects()` console API provided by the Chromium DevTools console. It can be used to search for objects that have the matching constructor on its prototype chain in the entire heap, which can be useful for memory leak regression tests. To avoid surprising results, users should avoid using this API on constructors whose implementation they don't control, or on constructors that can be invoked by other parties in the application. To avoid accidental leaks, this API does not return raw references to the objects found. By default, it returns the count of the objects found. If `options.format` is `'summary'`, it returns an array containing brief string representations for each object. The visibility provided in this API is similar to what the heap snapshot provides, while users can save the cost of serialization and parsing and directly filer the target objects during the search. We have been using this API internally for the test suite, which has been more stable than any other leak regression testing strategies in the CI. With a public implementation we can now use the public API instead. PR-URL: #51927 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: TODO

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492 doc: * update release gpg keyserver (marco-ippolito) nodejs#52257 * add release key for marco-ippolito (marco-ippolito) nodejs#52257 * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927 watch: * mark as stable (Moshe Atlow) nodejs#52074 PR-URL: nodejs#52793

yisibl · 2024-05-08T03:25:41Z

Hi @joyeecheung

There is also a queryHolders in Safari, could you consider introducing a similar feature in v8 and Node.js?

See also: https://www.zhihu.com/question/386595851/answer/1153444476

- nodejs/node#51999 - nodejs/node#51927

* chore: bump node in DEPS to v20.13.0 * crypto: enable NODE_EXTRA_CA_CERTS with BoringSSL nodejs/node#52217 * test: skip test for dynamically linked OpenSSL nodejs/node#52542 * lib, url: add a `windows` option to path parsing nodejs/node#52509 * src: use dedicated routine to compile function for builtin CJS loader nodejs/node#52016 * test: mark test as flaky nodejs/node#52671 * build,tools: add test-ubsan ci nodejs/node#46297 * src: preload function for Environment nodejs/node#51539 * chore: fixup patch indices * deps: update c-ares to 1.28.1 nodejs/node#52285 * chore: handle updated filenames - nodejs/node#51999 - nodejs/node#51927 * chore: bump node in DEPS to v20.13.1 * events: extract addAbortListener for safe internal use nodejs/node#52081 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * fs: add stacktrace to fs/promises nodejs/node#49849 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492 doc: * update release gpg keyserver (marco-ippolito) nodejs#52257 * add release key for marco-ippolito (marco-ippolito) nodejs#52257 * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927 watch: * mark as stable (Moshe Atlow) nodejs#52074 PR-URL: nodejs#52793

joyeecheung · 2024-07-02T20:50:28Z

Hi @yisibl thanks for bringing this up, discussed with the V8 & DevTooLs team and it seems the previously existing mechanism in V8 that allowed implementing it similar to how Safari did it has already been removed, and to implement this now it needs built-in support on snapshot analysis in V8 (which will be heavier compared to just tracking the retainers via heap iteration, but probably not too bad compared to having to serialize the snapshot and parse the JSON object before doing the analysis). I'll look into it although it will probably take some time to frutalize.

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 29, 2024

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 29, 2024

joyeecheung commented Feb 29, 2024

View reviewed changes

joyeecheung force-pushed the v8-query-objects branch from b8f05cd to f3163f0 Compare February 29, 2024 16:03

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 29, 2024

This comment was marked as outdated.

Sign in to view

joyeecheung force-pushed the v8-query-objects branch from f3163f0 to 6f58501 Compare February 29, 2024 16:06

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 29, 2024

joyeecheung force-pushed the v8-query-objects branch from 6f58501 to ac3a324 Compare February 29, 2024 16:12

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 29, 2024

This comment was marked as outdated.

Sign in to view

addaleax approved these changes Feb 29, 2024

View reviewed changes

joyeecheung added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. labels Feb 29, 2024

mertcanaltin approved these changes Feb 29, 2024

View reviewed changes

H4ad approved these changes Feb 29, 2024

View reviewed changes

Flarna approved these changes Mar 1, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

Qard approved these changes Mar 1, 2024

View reviewed changes

doc/api/v8.md Outdated Show resolved Hide resolved

fixup! v8: implement v8.queryObjects() for memory leak regression tes…

3e12aa8

…ting Co-authored-by: Stephen Belanger <[email protected]>

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 1, 2024

This comment was marked as outdated.

Sign in to view

Qard approved these changes Mar 2, 2024

View reviewed changes

RafaelGSS approved these changes Mar 2, 2024

View reviewed changes

H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 2, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2024

nodejs-github-bot merged commit 7f2d61f into nodejs:main Mar 2, 2024
58 checks passed

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

AbhiPrasad mentioned this pull request Apr 16, 2024

Support Node 22 getsentry/sentry-javascript#11455

Closed

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

codebytere added a commit to electron/electron that referenced this pull request May 8, 2024

chore: handle updated filenames

f3b22bf

- nodejs/node#51999 - nodejs/node#51927

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v8: implement v8.queryObjects() for memory leak regression testing #51927

v8: implement v8.queryObjects() for memory leak regression testing #51927

joyeecheung commented Feb 29, 2024 •

edited

Loading

nodejs-github-bot commented Feb 29, 2024

joyeecheung Feb 29, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

joyeecheung commented Feb 29, 2024

github-actions bot commented Feb 29, 2024

H4ad left a comment

nodejs-github-bot commented Feb 29, 2024

H4ad commented Feb 29, 2024 •

edited

Loading

joyeecheung commented Feb 29, 2024 •

edited

Loading

H4ad commented Feb 29, 2024

joyeecheung commented Feb 29, 2024 •

edited

Loading

This comment was marked as outdated.

Qard left a comment

This comment was marked as outdated.

RafaelGSS left a comment

nodejs-github-bot commented Mar 2, 2024

naugtur commented Mar 2, 2024

nodejs-github-bot commented Mar 2, 2024

yisibl commented May 8, 2024 •

edited

Loading

joyeecheung commented Jul 2, 2024 •

edited

Loading


		> Stability: 1.1 - Active development

		* `ctor` {Function} The constructor that can be used to search on the

v8: implement v8.queryObjects() for memory leak regression testing #51927

v8: implement v8.queryObjects() for memory leak regression testing #51927

Conversation

joyeecheung commented Feb 29, 2024 • edited Loading

nodejs-github-bot commented Feb 29, 2024

joyeecheung Feb 29, 2024 • edited Loading

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

joyeecheung commented Feb 29, 2024

github-actions bot commented Feb 29, 2024

H4ad left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Feb 29, 2024

H4ad commented Feb 29, 2024 • edited Loading

joyeecheung commented Feb 29, 2024 • edited Loading

H4ad commented Feb 29, 2024

joyeecheung commented Feb 29, 2024 • edited Loading

This comment was marked as outdated.

Qard left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

RafaelGSS left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 2, 2024

naugtur commented Mar 2, 2024

nodejs-github-bot commented Mar 2, 2024

yisibl commented May 8, 2024 • edited Loading

joyeecheung commented Jul 2, 2024 • edited Loading

joyeecheung commented Feb 29, 2024 •

edited

Loading

joyeecheung Feb 29, 2024 •

edited

Loading

H4ad commented Feb 29, 2024 •

edited

Loading

joyeecheung commented Feb 29, 2024 •

edited

Loading

joyeecheung commented Feb 29, 2024 •

edited

Loading

yisibl commented May 8, 2024 •

edited

Loading

joyeecheung commented Jul 2, 2024 •

edited

Loading