esm: drop support for import assertions #52104

nicolo-ribaudo · 2024-03-15T19:06:10Z

Description for changelog: #52104 (comment)

This patch removes support for the assert keyword for import attributes. It was an old variant of the proposal that was only shipped in V8 and no other
engine, and that has then been replaced by the with keyword.

Chrome is planning to remove support for assert
in version 126, which will be released in June.

Node.js already supports the with keyword for
import attributes, and this patch does not change that.

Fixes #51622

nodejs-github-bot · 2024-03-15T19:06:15Z

Review requested:

@nodejs/startup

aduh95 · 2024-03-15T19:40:15Z

Worth noting that v18.x does not support with syntax at all, so currently anyone trying to write code that uses import assertions/attributes has to use the older assert syntax to write code that works in all release lines. If/when this PR lands, there will be no way to write code that works everywhere. That being said, both syntaxes are experimental and therefore not subject to semver.

richardlau · 2024-03-15T20:54:15Z

Worth noting that v18.x does not support with syntax at all, so currently anyone trying to write code that uses import assertions/attributes has to use the older assert syntax to write code that works in all release lines. If/when this PR lands, there will be no way to write code that works everywhere. That being said, both syntaxes are experimental and therefore not subject to semver.

As I mentioned in #51622 (comment) I'm open to landing #51136 on v18.x.

nicolo-ribaudo · 2024-03-16T11:01:15Z

test/es-module/test-esm-import-attributes-errors.js

+
+  await rejects(
+    import(`data:text/javascript,import${JSON.stringify(jsonModuleDataUrl)}assert{type:"json"}`),
+    SyntaxError


This currently throws "unexpected token 'assert" -- I submitted a patch to V8 to make the error explicitly recommend to use 'with' instead: https://chromium-review.googlesource.com/c/v8/v8/+/5376260

This patch removes support for the `assert` keyword for import attributes. It was an old variant of the proposal that was only shipped in V8 and no other engine, and that has then been replaced by the `with` keyword. Chrome is planning to remove support for `assert` in version 126, which will be released in June. Node.js already supports the `with` keyword for import attributes, and this patch does not change that.

mcollina

lgtm

nodejs-github-bot · 2024-03-18T09:47:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57802/

joyeecheung · 2024-04-17T23:14:01Z

Since V8 will remove assert and it’s stage 3 going back to stage 2 and then broken in the spec anyway, is it semver major?(To me it looks more like experimental features and not subject to semver and @aduh95 also said something similar in #52104 (comment) ). It would not be great to continue having assert lingering around in v22 and then V8 breaks it and we cannot upgrade V8 on v22.

If it’s semver-major we should try getting it into v22 in time. Otherwise we can land it later on v22 (still nicer to have it in the beginning but I guess it’s not the end of the world to land it in 22.1.0 or something).

cc @targos @nodejs/releasers

nodejs-github-bot · 2024-04-17T23:19:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58482/

nicolo-ribaudo · 2024-04-18T06:47:49Z

The CI failures don't seem related to my changes, but maybe I should try rebasing? Or could somebody re-trigger CI?

The arm build is failing both on windows and OSX.

For the test failures on Linux, one is a timeout and the other one is marked as flaky.

nodejs-github-bot · 2024-04-18T07:23:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58486/

mcollina · 2024-04-18T07:54:23Z

@RafaelGSS this should be in v22

nicolo-ribaudo · 2024-04-18T09:43:36Z

Now the macOS failure is a flaky test (not ok 1443 parallel/test-http-server-headers-timeout-keepalive # TODO : Fix flaky test at https://ci.nodejs.org/job/node-test-commit-osx-arm/16770/nodes=osx11/consoleFull).

The failure on linux is a timeout:

09:37:39 not ok 483 async-hooks/test-writewrap
09:37:39   ---
09:37:39   duration_ms: 120041.78500
09:37:39   severity: fail
09:37:39   exitcode: -15
09:37:39   stack: |-
09:37:39     timeout

(out of curiosity, when you have to re-run CI due to flaky tests, do you re-run everything or just the failed jobs?)

targos · 2024-04-18T10:29:04Z

out of curiosity, when you have to re-run CI due to flaky tests, do you re-run everything or just the failed jobs?

When we use the "Resume build" button on Jenkins, it reruns all jobs that are either orange (only flaky failures) or red (at least one non-flaky failure).

nodejs-github-bot · 2024-04-18T10:30:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58488/

mcollina · 2024-04-18T10:30:35Z

@targos it does not seem I can rerun the GHA.

targos · 2024-04-18T10:32:00Z

It's probably too old to be re-runnable.

nicolo-ribaudo · 2024-04-18T10:45:26Z

Should I push an empty commit to retrigger it?

mcollina · 2024-04-18T10:50:57Z

let's see if the main CI passes first.

mcollina · 2024-04-18T14:40:28Z

Please push a fresh commit.

Replace keyword "assert" with "with" to support NodeJS v22+. Requires NodeJS v20.10+ or v18.20.x+ (LTS) PR that removes assert from NodeJS: nodejs/node#52104

Replace keyword "assert" with "with" to work with NodeJS v22+ Requires NodeJS v18.20.x+ (LTS) or v20.10+ NodeJS PR that removed the keyword: nodejs/node#52104

nodejs/node#52104 (comment)

nodejs/node#52104

- remove single usage of import assertion (import ... with/assert) which was breaking compat with older node 18 versions (see https://github.com/nodejs/node/pull/52104\#issuecomment-2000337367)

- remove import `with` keyword, see #492. tried replacing with newer `assert` syntax but it was [breaking](nodejs/node#52104 (comment)) older node 18 versions. - upgrade azure package to support node v22 - bump packaged oclif node version to latest LTS (20.13.1) - bump node version for CI workflows to 20.x - keep supported version in package.json to >=18.0.0 --------- Co-authored-by: Roy Razon <[email protected]>

These no longer build in Node 22 since import assertions were removed: nodejs/node#52104

* fix syntax error due to `assert` nodejs/node#52104 (comment) * fix missed assert thanks for pointing it out puxlit * bump nodejs version and regenerate package-lock.json per kocka's request

PR-URL: #55883 Refs: #52104 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: nodejs#55883 Refs: nodejs#52104 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: #55883 Refs: #52104 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 15, 2024

nicolo-ribaudo commented Mar 16, 2024

View reviewed changes

nicolo-ribaudo force-pushed the drop-assert branch from 462d735 to 4c227bd Compare March 16, 2024 11:07

mcollina approved these changes Mar 18, 2024

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024

nicolo-ribaudo mentioned this pull request Apr 13, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

joyeecheung approved these changes Apr 17, 2024

View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2024

anonrig approved these changes Apr 17, 2024

View reviewed changes

egemon mentioned this pull request Apr 30, 2024

An error occurred while running semantic-release: SyntaxError: Unexpected identifier 'assert' semantic-release/gitlab-config#325

Closed

Refusings added a commit to Refusings/Vencord that referenced this pull request Apr 30, 2024

Update common.mjs

8f24629

Replace keyword "assert" with "with" to support NodeJS v22+. Requires NodeJS v20.10+ or v18.20.x+ (LTS) PR that removes assert from NodeJS: nodejs/node#52104

Refusings mentioned this pull request Apr 30, 2024

Replace keyword "assert" with "with" for NodeJS v22+ support Vendicated/Vencord#2398

Closed

richardlau mentioned this pull request Apr 30, 2024

test/hook/v18-static-import-assert.mjs fails with SyntaxError: Unexpected identifier 'assert' with Node.js 22 nodejs/import-in-the-middle#73

Closed

ramaghanta mentioned this pull request May 1, 2024

CLI usage is throwing an error with node 22 vega/ts-json-schema-generator#1943

Closed

LunarTwilight added a commit to WikiaUsers/ContentReviewLog that referenced this pull request May 15, 2024

fix syntax error due to assert

fd9053b

nodejs/node#52104 (comment)

LunarTwilight mentioned this pull request May 15, 2024

fix syntax error due to assert WikiaUsers/ContentReviewLog#21

Merged

royra mentioned this pull request May 17, 2024

[Bug]: SyntaxError: Unexpected identifier 'assert' livecycle/preevy#492

Closed

kashz mentioned this pull request May 19, 2024

@gitbeaker/cli does not work on Node 22 jdalrymple/gitbeaker#3591

Closed

2 tasks

subs1stem added a commit to rosteleset/SmartYard-Server that referenced this pull request May 20, 2024

Replace 'assert' with 'with' in the event service code

48441b2

nodejs/node#52104

royra mentioned this pull request May 28, 2024

fix compatibility with node v22 livecycle/preevy#493

Merged

valadaptive added a commit to valadaptive/scratchblocks that referenced this pull request Jun 16, 2024

Replace import assertions with import attributes

f696538

These no longer build in Node 22 since import assertions were removed: nodejs/node#52104

valadaptive mentioned this pull request Jun 16, 2024

Replace import assertions with import attributes scratchblocks/scratchblocks#527

Closed

jakebailey mentioned this pull request Jul 26, 2024

[node] Add v22 typings DefinitelyTyped/DefinitelyTyped#70125

Merged

evert mentioned this pull request Aug 8, 2024

Import attributes break message exporting formatjs/formatjs#4489

Closed

janthomasQS mentioned this pull request Aug 9, 2024

Plugin does not work with NodeJS 22: Unexpected identifier 'assert' dimaMachina/graphql-eslint#2482

Closed

4 tasks

pcorpet mentioned this pull request Sep 22, 2024

Compatibility with Node v22 JesusTheHun/storybook-addon-remix-react-router#70

Closed

tinykite mentioned this pull request Nov 8, 2024

Quire new command fails with newer version of Node thegetty/quire#968

Open

1 task

gaoxiaoduan mentioned this pull request Nov 12, 2024

创建docker报错，日志如下 gaoxiaoduan/YoutubeToBilibiliHelp#13

Closed

aduh95 mentioned this pull request Nov 16, 2024

doc: add history entry for import assertion removal #55883

Merged

princed mentioned this pull request Nov 21, 2024

RudderTyper doesn't work on Node 22 rudderlabs/rudder-typer#86

Open

gillisandrew mentioned this pull request Nov 28, 2024

SyntaxError: Unexpected identifier 'assert' in Node 22 LTS actions/languageservices#144

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esm: drop support for import assertions #52104

esm: drop support for import assertions #52104

nicolo-ribaudo commented Mar 15, 2024 •

edited

Loading

nodejs-github-bot commented Mar 15, 2024

aduh95 commented Mar 15, 2024

richardlau commented Mar 15, 2024

nicolo-ribaudo Mar 16, 2024

mcollina left a comment

nodejs-github-bot commented Mar 18, 2024

joyeecheung commented Apr 17, 2024 •

edited

Loading

nodejs-github-bot commented Apr 17, 2024

nicolo-ribaudo commented Apr 18, 2024

nodejs-github-bot commented Apr 18, 2024

mcollina commented Apr 18, 2024

nicolo-ribaudo commented Apr 18, 2024 •

edited

Loading

targos commented Apr 18, 2024

nodejs-github-bot commented Apr 18, 2024

mcollina commented Apr 18, 2024

targos commented Apr 18, 2024

nicolo-ribaudo commented Apr 18, 2024

mcollina commented Apr 18, 2024

mcollina commented Apr 18, 2024

esm: drop support for import assertions #52104

esm: drop support for import assertions #52104

Conversation

nicolo-ribaudo commented Mar 15, 2024 • edited Loading

nodejs-github-bot commented Mar 15, 2024

aduh95 commented Mar 15, 2024

richardlau commented Mar 15, 2024

nicolo-ribaudo Mar 16, 2024

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 18, 2024

joyeecheung commented Apr 17, 2024 • edited Loading

nodejs-github-bot commented Apr 17, 2024

nicolo-ribaudo commented Apr 18, 2024

nodejs-github-bot commented Apr 18, 2024

mcollina commented Apr 18, 2024

nicolo-ribaudo commented Apr 18, 2024 • edited Loading

targos commented Apr 18, 2024

nodejs-github-bot commented Apr 18, 2024

mcollina commented Apr 18, 2024

targos commented Apr 18, 2024

nicolo-ribaudo commented Apr 18, 2024

mcollina commented Apr 18, 2024

mcollina commented Apr 18, 2024

nicolo-ribaudo commented Mar 15, 2024 •

edited

Loading

joyeecheung commented Apr 17, 2024 •

edited

Loading

nicolo-ribaudo commented Apr 18, 2024 •

edited

Loading