Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update process.execArg example to be more useful #52412

Merged

Conversation

JakobJingleheimer
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Apr 7, 2024
@JakobJingleheimer JakobJingleheimer added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 7, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

doc/api/process.md Outdated Show resolved Hide resolved
@JakobJingleheimer JakobJingleheimer requested a review from aduh95 April 8, 2024 18:20
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
doc/api/process.md Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <[email protected]>
@JakobJingleheimer JakobJingleheimer added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 8, 2024
doc/api/process.md Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2024
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Apr 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit c82f3c9 into nodejs:main Apr 9, 2024
19 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c82f3c9

@Noumanluckey8057
Copy link

👍

marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52412
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52412
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants