Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: gypify msi build #530

Closed
wants to merge 1 commit into from
Closed

WIP: gypify msi build #530

wants to merge 1 commit into from

Conversation

piscisaureus
Copy link
Contributor

Does not work yet

@piscisaureus
Copy link
Contributor Author

I got stuck on finding a good way of incorporating code signing (signtool.exe) into the build.

@rvagg
Copy link
Member

rvagg commented Jan 30, 2015

@piscisaureus what's the problem? it can't just be a separate, intermediate target prior to wix?

@piscisaureus
Copy link
Contributor Author

it can't just be a separate, intermediate target prior to wix?

That's the way to go indeed. However I didn't find a way to integrate this windows-only step nicely without affecting all the other platform builds.

  • signtool.exe modifies the .exe in-place which isn't really compatible with any build system. I'd have to make a copy and sign that.
  • The unsigned .exe file would need to have a different name than the final build product (unsigned/node.exe or node-unsigned.exe). This makes the output name depend on the ./configure flags, because on unix platforms (and windows when code signing is disabled) you'd still want to produce 'node.exe' as is done today.

@piscisaureus piscisaureus mentioned this pull request Feb 2, 2015
Closed
@brendanashworth brendanashworth added the windows Issues and PRs related to the Windows platform. label Mar 24, 2015
@brendanashworth brendanashworth added the wip Issues and PRs that are still a work in progress. label May 11, 2015
@Qard
Copy link
Member

Qard commented Jun 26, 2015

Any progress here, or should I close this as stale?

thefourtheye
thefourtheye reviewed Jun 26, 2015
View reviewed changes
configure
return

o['variables']['wix_bin_dir'] = os.path.abspath(os.path.join(
os.environ.get('WIX'), 'bin'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If WIX is not there in the dictionary we will get NoneType doesn't have ... error. It's better to fail with KeyError in that case.

@jasnell
Copy link
Member

jasnell commented Aug 22, 2015

@piscisaureus ... What do you want to do with this one?

@piscisaureus
Copy link
Contributor Author

@jasnell

It seemed like a neat idea to put all (windows) build steps inside gyp files, instead of spread out over gyp, a windows batch file, WiX. But I got stuck because I couldn't figure out how to do certain steps with gyp (e.g. signing the .exe which modifies the file in place and does not map to a gyp concept properly).

Currently I'm not working on this - feel free to close if you think it's not a priority.
It may also be an opportunity for another community member to take up and work on (and take credit for it - I'd be totally cool with that).

@jasnell
Copy link
Member

jasnell commented Oct 14, 2015

@nodejs/build

@jasnell jasnell added the build Issues and PRs related to build files or the CI. label Oct 14, 2015
@rvagg
Copy link
Member

rvagg commented Oct 15, 2015

/cc @nodejs/platform-windows

@orangemocha
Copy link
Contributor

Not sure if this a priority, though it's an interesting idea 😄 The main reason for using gyp is to generate projects for different platforms / build systems. Since MSI is 100% Windows-specific, dealing with Wix/MSBuild files directly actually seems easier to me.

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 22, 2016
@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

Marked as stalled. If there's no activity in the next few weeks I'll go ahead and close.

@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

Closing due to lack of activity.

@jasnell jasnell closed this Apr 2, 2016
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. stalled Issues and PRs that are stalled. windows Issues and PRs related to the Windows platform. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@piscisaureus @rvagg @Qard @jasnell @orangemocha @thefourtheye @chrisdickinson @brendanashworth