Revert "deps: V8: cherry-pick 9ebca66a5740" #53582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for revert: broke test-snapshot-reproducible.js in dynamically linked builds in the CI. This reverts commit 4c730ae.
|
Review requested:
|
nodejs-github-bot
added
build
joyeecheung
added
request-ci
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
targos
approved these changes
Jun 25, 2024
targos
added
the
dont-land-on-v22.x
gengjiawen
approved these changes
Jun 25, 2024
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
LGTM with the revert.
It's curious that the failure didn't occur in the PR CI: https://ci.nodejs.org/job/node-test-pull-request/59933/. It also runs the dynamically linked builds test: https://ci.nodejs.org/job/node-test-commit-linux-containered/44105/parameters/
richardlau
approved these changes
Jun 25, 2024
sxa
approved these changes
Jun 25, 2024
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53582 ✔ Done loading data for nodejs/node/pull/53582 ----------------------------------- PR info ------------------------------------ Title Revert "deps: V8: cherry-pick 9ebca66a5740" (#53582) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:revert-v8 -> nodejs:main Labels fast-track, dont-land-on-v22.x Commits 1 - Revert "deps: V8: cherry-pick 9ebca66a5740" Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/53582 Refs: https://github.com/nodejs/node/issues/53579 Reviewed-By: Michaël Zasso Reviewed-By: Moshe Atlow Reviewed-By: Jiawen Geng Reviewed-By: Chengzhong Wu Reviewed-By: Richard Lau Reviewed-By: Stewart X Addison ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53582 Refs: https://github.com/nodejs/node/issues/53579 Reviewed-By: Michaël Zasso Reviewed-By: Moshe Atlow Reviewed-By: Jiawen Geng Reviewed-By: Chengzhong Wu Reviewed-By: Richard Lau Reviewed-By: Stewart X Addison -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 25 Jun 2024 09:12:08 GMT ✔ Approvals: 6 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2137991739 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2137994149 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/53582#pullrequestreview-2137997217 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2138346109 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2138562753 ✔ - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/53582#pullrequestreview-2138603737 ℹ This PR is being fast-tracked ✘ This PR needs to wait 40 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-25T11:27:14Z: https://ci.nodejs.org/job/node-test-pull-request/59933/. - Querying data for job/node-test-pull-request/59933/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9666246956 |
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8e33f20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "deps: V8: cherry-pick 9ebca66a5740"
Reason for revert: broke test-snapshot-reproducible.js in
dynamically linked builds in the CI.
This reverts commit 4c730ae.
Refs: #53579