Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: move ToNamespacedPath dir calls to c++ #53630

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fs: move ToNamespacedPath dir calls to c++ #53630

merged 1 commit into from
Jul 11, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jun 28, 2024

Moves toNamespacedPath calls to C++ just like the rest of node:fs

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 28, 2024
@anonrig anonrig added the review wanted PRs that need reviews. label Jun 29, 2024
@anonrig
Copy link
Member Author

anonrig commented Jun 29, 2024

cc @nodejs/url @nodejs/fs @nodejs/cpp-reviewers

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2024
@anonrig anonrig removed the review wanted PRs that need reviews. label Jul 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60038/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60224/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60251/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3ad2e12 into nodejs:main Jul 11, 2024
71 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3ad2e12

aduh95 pushed a commit that referenced this pull request Jul 12, 2024
@anonrig @aduh95
fs: move ToNamespacedPath dir calls to c++
b9d9201 
PR-URL: #53630
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@aduh95 aduh95 mentioned this pull request Jul 12, 2024
Merged
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@anonrig @aduh95
fs: move ToNamespacedPath dir calls to c++
076e82c 
PR-URL: #53630
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@anonrig @ehsankhfr
fs: move ToNamespacedPath dir calls to c++
706c71c 
PR-URL: nodejs#53630
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@jasnell jasnell jasnell approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @Qard @jasnell @H4ad @targos